Menu for the OSX app launcher.

ui/base/cocoa/controls/hover_image_menu_button.h

Index: ui/base/cocoa/controls/hover_image_menu_button.h
diff --git a/ui/base/cocoa/controls/hover_image_menu_button.h b/ui/base/cocoa/controls/hover_image_menu_button.h
new file mode 100644
index 0000000000000000000000000000000000000000..fe3ad6b80b1de145f68a3c041cf4e155f3c8efba
--- /dev/null
+++ b/ui/base/cocoa/controls/hover_image_menu_button.h
@@ -0,0 +1,25 @@
+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef UI_BASE_COCOA_CONTROLS_HOVER_IMAGE_MENU_BUTTON_H_
+#define UI_BASE_COCOA_CONTROLS_HOVER_IMAGE_MENU_BUTTON_H_
+
+#import <Cocoa/Cocoa.h>
+
+#import "ui/base/cocoa/controls/hover_image_menu_button_cell.h"

[tapted, 2013/05/31 09:37:39]

Not sure if this is conventional.. it felt weird to include both button and cell
headers in order to see [[button cell] setHoverImage:]. Maybe it should just be
collapsed into one file?

[sail, 2013/05/31 19:07:03]

I think it's ok. But you don't actually use it in this file so can you move this
into the .mm file?

[tapted, 2013/06/03 12:49:18]

Done.

+#import "ui/base/cocoa/tracking_area.h"
+
+// An NSPopUpButton that additionally tracks mouseover state, and calls
+// [[self cell] setHovered:flag] when the hover state changes. Uses
+// HoverImageMenuButtonCell as the default cellClass. Note that the menu item at
+// index 0 is ignored and will be pre-populated with a dummy item.
+// Initialize with initWithFrame:pullsDown:.

[sail, 2013/05/31 19:07:03]

Don't need this comment. This is the designated initializer for NSPopupButton.
Unless you specify a new designated initializer callers should already know to
use that one.

[tapted, 2013/06/03 12:49:18]

Done.

+@interface HoverImageMenuButton : NSPopUpButton {
+ @private
+  ui::ScopedCrTrackingArea trackingArea_;
+}
+

[sail, 2013/05/31 19:07:03]

Maybe add a
- (HoverImageMenuButtonCell*)hoverImageMenuButtonCell;
method here?

[tapted, 2013/06/03 12:49:18]

Done.

+@end
+
+#endif  // UI_BASE_COCOA_CONTROLS_HOVER_IMAGE_MENU_BUTTON_H_