ui/base/cocoa/controls/hover_image_menu_button.h - Issue 15955003: Menu for the OSX app launcher.

Side by Side Diff: ui/base/cocoa/controls/hover_image_menu_button.h

Issue 15955003: Menu for the OSX app launcher. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Refactor HoverImageMenuButton into /ui/base/cocoa/controls Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« ui/app_list/cocoa/current_user_menu_item_view.mm ('K') | « ui/app_list/cocoa/current_user_menu_item_view.mm ('k') | ui/base/cocoa/controls/hover_image_menu_button.mm » ('j') | ui/base/cocoa/controls/hover_image_menu_button.mm » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2013 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef UI_BASE_COCOA_CONTROLS_HOVER_IMAGE_MENU_BUTTON_H_

	6 #define UI_BASE_COCOA_CONTROLS_HOVER_IMAGE_MENU_BUTTON_H_

	7

	8 #import <Cocoa/Cocoa.h>

	9

	10 #import "ui/base/cocoa/controls/hover_image_menu_button_cell.h"
	tapted 2013/05/31 09:37:39 Not sure if this is conventional.. it felt weird t Not sure if this is conventional.. it felt weird to include both button and cell headers in order to see [[button cell] setHoverImage:]. Maybe it should just be collapsed into one file? sail 2013/05/31 19:07:03 I think it's ok. But you don't actually use it in Show quoted text On 2013/05/31 09:37:39, tapted wrote: > Not sure if this is conventional.. it felt weird to include both button and cell > headers in order to see [[button cell] setHoverImage:]. Maybe it should just be > collapsed into one file? I think it's ok. But you don't actually use it in this file so can you move this into the .mm file? tapted 2013/06/03 12:49:18 Done. Show quoted text On 2013/05/31 19:07:03, sail wrote: > On 2013/05/31 09:37:39, tapted wrote: > > Not sure if this is conventional.. it felt weird to include both button and > cell > > headers in order to see [[button cell] setHoverImage:]. Maybe it should just > be > > collapsed into one file? > > I think it's ok. But you don't actually use it in this file so can you move this > into the .mm file? Done.
	11 #import "ui/base/cocoa/tracking_area.h"

	12

	13 // An NSPopUpButton that additionally tracks mouseover state, and calls

	14 // [[self cell] setHovered:flag] when the hover state changes. Uses

	15 // HoverImageMenuButtonCell as the default cellClass. Note that the menu item at

	16 // index 0 is ignored and will be pre-populated with a dummy item.

	17 // Initialize with initWithFrame:pullsDown:.
	sail 2013/05/31 19:07:03 Don't need this comment. This is the designated in Don't need this comment. This is the designated initializer for NSPopupButton. Unless you specify a new designated initializer callers should already know to use that one. tapted 2013/06/03 12:49:18 Done. Show quoted text On 2013/05/31 19:07:03, sail wrote: > Don't need this comment. This is the designated initializer for NSPopupButton. > Unless you specify a new designated initializer callers should already know to > use that one. Done.
	18 @interface HoverImageMenuButton : NSPopUpButton {

	19 @private

	20 ui::ScopedCrTrackingArea trackingArea_;

	21 }

	22
	sail 2013/05/31 19:07:03 Maybe add a - (HoverImageMenuButtonCell)hoverImag Maybe add a - (HoverImageMenuButtonCell)hoverImageMenuButtonCell; method here? tapted 2013/06/03 12:49:18 Done. Show quoted text On 2013/05/31 19:07:03, sail wrote: > Maybe add a > - (HoverImageMenuButtonCell*)hoverImageMenuButtonCell; > method here? Done.
	23 @end

	24

	25 #endif // UI_BASE_COCOA_CONTROLS_HOVER_IMAGE_MENU_BUTTON_H_

OLD	NEW