Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 159527: Create render view for extensions on Linux. (Closed)

Created:
11 years, 4 months ago by Paweł Hajdan Jr.
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Create render view for extensions on Linux. Now when an extension is loaded, you will see its entry in the task manager. However, on the shelf there is still only a placeholder label (I have to work on setting proper size for the render widget). TEST=none http://crbug.com/16759 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21908

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -2 lines) Patch
M chrome/browser/extensions/extension_host.h View 3 chunks +7 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gtk/extension_shelf_gtk.cc View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/browser/gtk/extension_view_gtk.h View 1 chunk +33 lines, -0 lines 0 comments Download
A chrome/browser/gtk/extension_view_gtk.cc View 1 chunk +31 lines, -0 lines 0 comments Download
M chrome/chrome.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Paweł Hajdan Jr.
Please review: erg: GTK parts aa: extension parts
11 years, 4 months ago (2009-07-28 19:07:47 UTC) #1
Elliot Glaysher
GTK parts LGTM
11 years, 4 months ago (2009-07-28 19:23:58 UTC) #2
Aaron Boodman
11 years, 4 months ago (2009-07-28 22:38:28 UTC) #3
Other parts LGTM

Powered by Google App Engine
This is Rietveld 408576698