Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Side by Side Diff: chrome/browser/extensions/extension_host.cc

Issue 159527: Create render view for extensions on Linux. (Closed)
Patch Set: Created 11 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/extensions/extension_host.h ('k') | chrome/browser/gtk/extension_shelf_gtk.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2006-2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/extension_host.h" 5 #include "chrome/browser/extensions/extension_host.h"
6 6
7 #include "app/l10n_util.h" 7 #include "app/l10n_util.h"
8 #include "app/resource_bundle.h" 8 #include "app/resource_bundle.h"
9 #include "base/string_util.h" 9 #include "base/string_util.h"
10 #include "chrome/browser/browser.h" 10 #include "chrome/browser/browser.h"
(...skipping 92 matching lines...) Expand 10 before | Expand all | Expand 10 after
103 render_view_host_->Shutdown(); // deletes render_view_host 103 render_view_host_->Shutdown(); // deletes render_view_host
104 } 104 }
105 105
106 void ExtensionHost::CreateView(Browser* browser) { 106 void ExtensionHost::CreateView(Browser* browser) {
107 #if defined(TOOLKIT_VIEWS) 107 #if defined(TOOLKIT_VIEWS)
108 view_.reset(new ExtensionView(this, browser)); 108 view_.reset(new ExtensionView(this, browser));
109 // We own |view_|, so don't auto delete when it's removed from the view 109 // We own |view_|, so don't auto delete when it's removed from the view
110 // hierarchy. 110 // hierarchy.
111 view_->SetParentOwned(false); 111 view_->SetParentOwned(false);
112 #elif defined(OS_LINUX) 112 #elif defined(OS_LINUX)
113 // FIXME(phajdan.jr): Add extension view for GTK. 113 view_.reset(new ExtensionViewGtk(this));
114 #else 114 #else
115 // TODO(port) 115 // TODO(port)
116 NOTREACHED(); 116 NOTREACHED();
117 #endif 117 #endif
118 } 118 }
119 119
120 RenderProcessHost* ExtensionHost::render_process_host() const { 120 RenderProcessHost* ExtensionHost::render_process_host() const {
121 return render_view_host_->process(); 121 return render_view_host_->process();
122 } 122 }
123 123
(...skipping 222 matching lines...) Expand 10 before | Expand all | Expand 10 after
346 // a toolstrip or background_page onload chrome.tabs api call can make it 346 // a toolstrip or background_page onload chrome.tabs api call can make it
347 // into here before the browser is sufficiently initialized to return here. 347 // into here before the browser is sufficiently initialized to return here.
348 // A similar situation may arise during shutdown. 348 // A similar situation may arise during shutdown.
349 // TODO(rafaelw): Delay creation of background_page until the browser 349 // TODO(rafaelw): Delay creation of background_page until the browser
350 // is available. http://code.google.com/p/chromium/issues/detail?id=13284 350 // is available. http://code.google.com/p/chromium/issues/detail?id=13284
351 return browser; 351 return browser;
352 } 352 }
353 353
354 void ExtensionHost::RenderViewCreated(RenderViewHost* render_view_host) { 354 void ExtensionHost::RenderViewCreated(RenderViewHost* render_view_host) {
355 } 355 }
OLDNEW
« no previous file with comments | « chrome/browser/extensions/extension_host.h ('k') | chrome/browser/gtk/extension_shelf_gtk.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698