Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issue 1595103006: [Interpreter] Preparation for wide registers. (Closed)

Created:
4 years, 11 months ago by oth
Modified:
4 years, 11 months ago
CC:
v8-reviews_googlegroups.com, mythria, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Preparation for wide registers. o Adds wide variants of bytecodes that have operands describing ranges of registers. The upcoming wide register support does not suppport re-mapping ranges. o Adds kRegPair16 and kRegTriple16 operands required for new wide bytecodes and renames Count8/Count16 operands to RegCount8/RegCount16. o Removes Exchange bytecodes BUG=v8:4675 LOG=NO Committed: https://crrev.com/68654b6476889de2409bebb68b357eca476ecd09 Cr-Commit-Position: refs/heads/master@{#33389}

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+521 lines, -365 lines) Patch
M src/compiler/bytecode-graph-builder.h View 2 chunks +7 lines, -0 lines 0 comments Download
M src/compiler/bytecode-graph-builder.cc View 12 chunks +80 lines, -16 lines 0 comments Download
M src/compiler/interpreter-assembler.cc View 2 chunks +17 lines, -9 lines 0 comments Download
M src/interpreter/bytecode-array-builder.h View 6 chunks +13 lines, -16 lines 0 comments Download
M src/interpreter/bytecode-array-builder.cc View 20 chunks +148 lines, -97 lines 0 comments Download
M src/interpreter/bytecode-array-iterator.cc View 2 chunks +11 lines, -3 lines 0 comments Download
M src/interpreter/bytecodes.h View 6 chunks +53 lines, -24 lines 0 comments Download
M src/interpreter/bytecodes.cc View 5 chunks +38 lines, -19 lines 0 comments Download
M src/interpreter/interpreter.h View 1 chunk +12 lines, -0 lines 0 comments Download
M src/interpreter/interpreter.cc View 9 chunks +113 lines, -44 lines 0 comments Download
M test/cctest/interpreter/test-bytecode-generator.cc View 1 3 chunks +3 lines, -2 lines 0 comments Download
M test/cctest/interpreter/test-interpreter.cc View 1 1 chunk +0 lines, -111 lines 0 comments Download
M test/unittests/compiler/interpreter-assembler-unittest.cc View 3 chunks +5 lines, -2 lines 0 comments Download
M test/unittests/interpreter/bytecode-array-builder-unittest.cc View 6 chunks +21 lines, -22 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
oth
Phase 1 of wide register support. PTAL, thanks!
4 years, 11 months ago (2016-01-19 11:11:36 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1595103006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1595103006/1
4 years, 11 months ago (2016-01-19 11:25:40 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-19 11:53:45 UTC) #7
rmcilroy
LGTM, thanks!
4 years, 11 months ago (2016-01-19 12:42:40 UTC) #8
oth
mstarzinger@chromium.org: Please review changes in compiler, thanks!
4 years, 11 months ago (2016-01-19 12:44:16 UTC) #10
Michael Starzinger
LGTM on "compiler", didn't look through the rest.
4 years, 11 months ago (2016-01-19 13:55:47 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1595103006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1595103006/20001
4 years, 11 months ago (2016-01-19 15:54:11 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-19 16:06:15 UTC) #16
commit-bot: I haz the power
4 years, 11 months ago (2016-01-19 16:07:10 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/68654b6476889de2409bebb68b357eca476ecd09
Cr-Commit-Position: refs/heads/master@{#33389}

Powered by Google App Engine
This is Rietveld 408576698