Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1595063002: Adds AX role for abbr tag. (Closed)

Created:
4 years, 11 months ago by je_julie(Not used)
Modified:
4 years, 11 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, extensions-reviews_chromium.org, mlamouri+watch-test-runner_chromium.org, plundblad+watch_chromium.org, mlamouri+watch-content_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, dmazzoni, jam, dglazkov+blink, yuzo+watch_chromium.org, aboxhall, blink-reviews, nektarios, je_julie, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, chromium-apps-reviews_chromium.org, blink-reviews-api_chromium.org, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adds AX role for abbr tag. This patch makes abbr tag have ROLE_SYSTEM_TEXT, IA2_ROLE_TEXT_FRAME and AXGroup. BUG=538537 Committed: https://crrev.com/533de374183ff13b9e62a46605750a431b929949 Cr-Commit-Position: refs/heads/master@{#370338}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -4 lines) Patch
M chrome/common/extensions/api/automation.idl View 1 chunk +1 line, -0 lines 0 comments Download
M components/test_runner/web_ax_object_proxy.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_win.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/accessibility/blink_ax_enum_conversion.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/test/data/accessibility/html/abbr-expected-mac.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M content/test/data/accessibility/html/abbr-expected-win.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXObject.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXObject.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/web/AssertMatchingEnums.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/public/web/WebAXEnums.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/accessibility/ax_enums.idl View 1 chunk +1 line, -0 lines 0 comments Download
M ui/accessibility/platform/ax_platform_node_mac.mm View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
je_julie(Not used)
Hi Dominic, PTAL.
4 years, 11 months ago (2016-01-17 14:25:26 UTC) #2
dmazzoni
lgtm
4 years, 11 months ago (2016-01-20 01:12:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1595063002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1595063002/1
4 years, 11 months ago (2016-01-20 06:20:26 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-20 08:45:07 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-20 08:46:31 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/533de374183ff13b9e62a46605750a431b929949
Cr-Commit-Position: refs/heads/master@{#370338}

Powered by Google App Engine
This is Rietveld 408576698