Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Side by Side Diff: third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp

Issue 1595063002: Adds AX role for abbr tag. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2008 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 641 matching lines...) Expand 10 before | Expand all | Expand 10 after
652 Node* node = m_layoutObject->node(); 652 Node* node = m_layoutObject->node();
653 if (isHTMLLabelElement(node)) 653 if (isHTMLLabelElement(node))
654 return false; 654 return false;
655 655
656 // Anything that is content editable should not be ignored. 656 // Anything that is content editable should not be ignored.
657 // However, one cannot just call node->hasEditableStyle() since that will as k if its parents 657 // However, one cannot just call node->hasEditableStyle() since that will as k if its parents
658 // are also editable. Only the top level content editable region should be e xposed. 658 // are also editable. Only the top level content editable region should be e xposed.
659 if (hasContentEditableAttributeSet()) 659 if (hasContentEditableAttributeSet())
660 return false; 660 return false;
661 661
662 if (roleValue() == AbbrRole)
663 return false;
664
662 // List items play an important role in defining the structure of lists. The y should not be ignored. 665 // List items play an important role in defining the structure of lists. The y should not be ignored.
663 if (roleValue() == ListItemRole) 666 if (roleValue() == ListItemRole)
664 return false; 667 return false;
665 668
666 if (roleValue() == BlockquoteRole) 669 if (roleValue() == BlockquoteRole)
667 return false; 670 return false;
668 671
669 if (roleValue() == DialogRole) 672 if (roleValue() == DialogRole)
670 return false; 673 return false;
671 674
(...skipping 1861 matching lines...) Expand 10 before | Expand all | Expand 10 after
2533 if (label && label->layoutObject()) { 2536 if (label && label->layoutObject()) {
2534 LayoutRect labelRect = axObjectCache().getOrCreate(label)->elementRe ct(); 2537 LayoutRect labelRect = axObjectCache().getOrCreate(label)->elementRe ct();
2535 result.unite(labelRect); 2538 result.unite(labelRect);
2536 } 2539 }
2537 } 2540 }
2538 2541
2539 return result; 2542 return result;
2540 } 2543 }
2541 2544
2542 } // namespace blink 2545 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698