Do not cause unnecessary node lists invalidation on id/name attribute change

Source/core/dom/NodeRareData.h

 /*
  * Copyright (C) 2008, 2010 Apple Inc. All rights reserved.
  * Copyright (C) 2008 David Smith <catfish.man@gmail.com>
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
@@ skipping 155 matching lines @@
         return m_atomicNameCaches.isEmpty() && m_tagCollectionCacheNS.isEmpty();
     }
 
     void adoptTreeScope()
     {
         invalidateCaches();
     }
 
     void adoptDocument(Document& oldDocument, Document& newDocument)
     {
-        invalidateCaches();
+        if (oldDocument == newDocument) {

[eseidel, 2014/02/12 01:55:24]

Really?  This seems like an odd case?

[Inactive, 2014/02/12 02:21:41]

Right, I need to check the callers to see if this actually happens, I kept the
condition because it was already there, I merely refactor the code to do an
early return.

[Inactive, 2014/02/12 02:38:48]

After a quick check, it looks like all the callers already make sure that
oldDocument is different than newDocument before calling this method. I will
address this in a separate CL.

+            invalidateCaches();
+            return;
 
-        if (oldDocument != newDocument) {
-            NodeListAtomicNameCacheMap::const_iterator atomicNameCacheEnd = m_atomicNameCaches.end();
-            for (NodeListAtomicNameCacheMap::const_iterator it = m_atomicNameCaches.begin(); it != atomicNameCacheEnd; ++it) {
-                LiveNodeListBase* list = it->value;
-                oldDocument.unregisterNodeList(list);
-                newDocument.registerNodeList(list);
-            }
+        }
+        NodeListAtomicNameCacheMap::const_iterator atomicNameCacheEnd = m_atomicNameCaches.end();
+        for (NodeListAtomicNameCacheMap::const_iterator it = m_atomicNameCaches.begin(); it != atomicNameCacheEnd; ++it) {
+            LiveNodeListBase* list = it->value;
+            list->didMoveToDocument(oldDocument, newDocument);
+        }
 
-            TagCollectionCacheNS::const_iterator tagEnd = m_tagCollectionCacheNS.end();
-            for (TagCollectionCacheNS::const_iterator it = m_tagCollectionCacheNS.begin(); it != tagEnd; ++it) {
-                LiveNodeListBase* list = it->value;
-                ASSERT(!list->isRootedAtDocument());
-                oldDocument.unregisterNodeList(list);
-                newDocument.registerNodeList(list);
-            }
+        TagCollectionCacheNS::const_iterator tagEnd = m_tagCollectionCacheNS.end();
+        for (TagCollectionCacheNS::const_iterator it = m_tagCollectionCacheNS.begin(); it != tagEnd; ++it) {
+            LiveNodeListBase* list = it->value;
+            ASSERT(!list->isRootedAtDocument());
+            list->didMoveToDocument(oldDocument, newDocument);
         }
     }
 
 private:
     NodeListsNodeData()
         : m_childNodeList(0)
     { }
 
     std::pair<unsigned char, StringImpl*> namedNodeListKey(CollectionType type, const AtomicString& name)
     {
@@ skipping 78 matching lines @@
     ownerNode->clearNodeLists();
     return true;
 }
 
 // Ensure the 10 bits reserved for the m_connectedFrameCount cannot overflow
 COMPILE_ASSERT(Page::maxNumberOfFrames < 1024, Frame_limit_should_fit_in_rare_data_count);
 
 } // namespace WebCore
 
 #endif // NodeRareData_h