Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Side by Side Diff: Source/core/html/HTMLAllCollection.cpp

Issue 159503003: Do not cause unnecessary node lists invalidation on id/name attribute change (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Code clean up Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009, 2011, 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2009, 2011, 2012 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 30 matching lines...) Expand all
41 { 41 {
42 ScriptWrappable::init(this); 42 ScriptWrappable::init(this);
43 } 43 }
44 44
45 HTMLAllCollection::~HTMLAllCollection() 45 HTMLAllCollection::~HTMLAllCollection()
46 { 46 {
47 } 47 }
48 48
49 Element* HTMLAllCollection::namedItemWithIndex(const AtomicString& name, unsigne d index) const 49 Element* HTMLAllCollection::namedItemWithIndex(const AtomicString& name, unsigne d index) const
50 { 50 {
51 updateNameCache(); 51 updateIdNameCache();
52 52
53 if (Vector<Element*>* cache = idCache(name)) { 53 if (Vector<Element*>* cache = idCache(name)) {
54 if (index < cache->size()) 54 if (index < cache->size())
55 return cache->at(index); 55 return cache->at(index);
56 index -= cache->size(); 56 index -= cache->size();
57 } 57 }
58 58
59 if (Vector<Element*>* cache = nameCache(name)) { 59 if (Vector<Element*>* cache = nameCache(name)) {
60 if (index < cache->size()) 60 if (index < cache->size())
61 return cache->at(index); 61 return cache->at(index);
(...skipping 16 matching lines...) Expand all
78 return; 78 return;
79 } 79 }
80 80
81 // FIXME: HTML5 specification says this should be a HTMLCollection. 81 // FIXME: HTML5 specification says this should be a HTMLCollection.
82 // http://www.whatwg.org/specs/web-apps/current-work/multipage/common-dom-in terfaces.html#htmlallcollection 82 // http://www.whatwg.org/specs/web-apps/current-work/multipage/common-dom-in terfaces.html#htmlallcollection
83 returnValue0Enabled = true; 83 returnValue0Enabled = true;
84 returnValue0 = NamedNodesCollection::create(namedItems); 84 returnValue0 = NamedNodesCollection::create(namedItems);
85 } 85 }
86 86
87 } // namespace WebCore 87 } // namespace WebCore
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698