Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(530)

Unified Diff: net/quic/quic_client_session.cc

Issue 15950009: Add histograms for tracking the number of client hellos send. This will let us understand how frequ… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_client_session.cc
diff --git a/net/quic/quic_client_session.cc b/net/quic/quic_client_session.cc
index 493dac848d5f12dfc4a6bd3275a5b97d6a0f6fa7..a5b3121f86dfd91c08b26df07c91b3eb8a960b7f 100644
--- a/net/quic/quic_client_session.cc
+++ b/net/quic/quic_client_session.cc
@@ -6,6 +6,7 @@
#include "base/callback_helpers.h"
#include "base/message_loop.h"
+#include "base/metrics/histogram.h"
#include "base/stl_util.h"
#include "base/string_number_conversions.h"
#include "base/values.h"
@@ -53,6 +54,16 @@ QuicClientSession::~QuicClientSession() {
DCHECK(callback_.is_null());
connection()->set_debug_visitor(NULL);
net_log_.EndEvent(NetLog::TYPE_QUIC_SESSION);
+ UMA_HISTOGRAM_BOOLEAN("Net.QuicCryptoHandshakeConfirmed",
+ IsCryptoHandshakeConfirmed());
+ UMA_HISTOGRAM_BOOLEAN("Net.QuicEncryptionEstablished",
+ IsEncryptionEstablished());
+ UMA_HISTOGRAM_COUNTS("Net.QuicNumSentClientHellos",
jar (doing other things) 2013/05/30 21:08:33 maybe better: UMA_HISTOGRAM_ENUMERATION("...", sa
+ crypto_stream_->num_sent_client_hellos());
+ if (IsCryptoHandshakeConfirmed()) {
+ UMA_HISTOGRAM_COUNTS("Net.QuicCryptoHandshakeConfirmedNumSentClientHellos",
jar (doing other things) 2013/05/30 21:08:33 nit: To get better ordering of histograms... alpha
+ crypto_stream_->num_sent_client_hellos());
+ }
}
QuicReliableClientStream* QuicClientSession::CreateOutgoingReliableStream() {
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698