Add histograms for tracking the number of client hellos send. This will let us understand how frequ…

net/quic/quic_client_session.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/quic/quic_client_session.h"
 
 #include "base/callback_helpers.h"
 #include "base/message_loop.h"
+#include "base/metrics/histogram.h"
 #include "base/stl_util.h"
 #include "base/string_number_conversions.h"
 #include "base/values.h"
 #include "net/base/io_buffer.h"
 #include "net/base/net_errors.h"
 #include "net/quic/quic_connection_helper.h"
 #include "net/quic/quic_crypto_client_stream_factory.h"
 #include "net/quic/quic_stream_factory.h"
 #include "net/udp/datagram_client_socket.h"
 
@@ skipping 27 matching lines @@
   // TODO(rch): pass in full host port proxy pair
   net_log_.BeginEvent(
       NetLog::TYPE_QUIC_SESSION,
       NetLog::StringCallback("host", &server_hostname));
 }
 
 QuicClientSession::~QuicClientSession() {
   DCHECK(callback_.is_null());
   connection()->set_debug_visitor(NULL);
   net_log_.EndEvent(NetLog::TYPE_QUIC_SESSION);
+  UMA_HISTOGRAM_BOOLEAN("Net.QuicCryptoHandshakeConfirmed",
+                        IsCryptoHandshakeConfirmed());
+  UMA_HISTOGRAM_BOOLEAN("Net.QuicEncryptionEstablished",
+                        IsEncryptionEstablished());
+  UMA_HISTOGRAM_COUNTS("Net.QuicNumSentClientHellos",

[jar (doing other things), 2013/05/30 21:08:33]

maybe better:

UMA_HISTOGRAM_ENUMERATION("...", sample, max+1);

+                       crypto_stream_->num_sent_client_hellos());
+  if (IsCryptoHandshakeConfirmed()) {
+    UMA_HISTOGRAM_COUNTS("Net.QuicCryptoHandshakeConfirmedNumSentClientHellos",

[jar (doing other things), 2013/05/30 21:08:33]

nit: To get better ordering of histograms... alphabetize near the similar one:

Net.QuicNumSentClientHellosCryptoHandshakeConfirmed

+                         crypto_stream_->num_sent_client_hellos());
+  }
 }
 
 QuicReliableClientStream* QuicClientSession::CreateOutgoingReliableStream() {
   if (!crypto_stream_->encryption_established()) {
     DLOG(INFO) << "Encryption not active so no outgoing stream created.";
     return NULL;
   }
   if (GetNumOpenStreams() >= get_max_open_streams()) {
     DLOG(INFO) << "Failed to create a new outgoing stream. "
                << "Already " << GetNumOpenStreams() << " open.";
@@ skipping 131 matching lines @@
   // use a weak pointer to be safe.
   connection()->ProcessUdpPacket(local_address, peer_address, packet);
   if (!connection()->connected()) {
     stream_factory_->OnSessionClose(this);
     return;
   }
   StartReading();
 }
 
 }  // namespace net