Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 15950009: Add histograms for tracking the number of client hellos send. This will let us understand how frequ… (Closed)

Created:
7 years, 6 months ago by Ryan Hamilton
Modified:
7 years, 6 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, Ilya Sherman, jar (doing other things), MAD
Visibility:
Public.

Description

Add histograms for tracking the number of client hellos send. This will let us understand how frequently we are able to make use of the 0RTT handshake. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203311

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix "comments" #

Patch Set 3 : Use helper function #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -0 lines) Patch
M net/quic/quic_client_session.cc View 1 2 4 chunks +35 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 chunks +25 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Ryan Hamilton
7 years, 6 months ago (2013-05-29 22:37:15 UTC) #1
Ryan Hamilton
7 years, 6 months ago (2013-05-30 20:02:12 UTC) #2
jar (doing other things)
Two comments... but per our discussion, it may be nice to track QUIC stream creation ...
7 years, 6 months ago (2013-05-30 21:08:32 UTC) #3
Ryan Hamilton
ptal
7 years, 6 months ago (2013-05-30 21:15:35 UTC) #4
jar (doing other things)
lgtm
7 years, 6 months ago (2013-05-30 23:08:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/15950009/8001
7 years, 6 months ago (2013-05-30 23:32:27 UTC) #6
commit-bot: I haz the power
7 years, 6 months ago (2013-05-31 02:15:07 UTC) #7
Message was sent while issue was closed.
Change committed as 203311

Powered by Google App Engine
This is Rietveld 408576698