Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Unified Diff: components/cronet/android/chromium_url_request.cc

Issue 1594973004: Remove use of void** from HttpResponseHeaders::EnumerateHeaderLines (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/chromium_url_request.cc
diff --git a/components/cronet/android/chromium_url_request.cc b/components/cronet/android/chromium_url_request.cc
index 2e824091a554f88f2f07d2d63798a2dfa3d00dbd..1eea66073877a958b91c46b2df2eb85f68c3c086 100644
--- a/components/cronet/android/chromium_url_request.cc
+++ b/components/cronet/android/chromium_url_request.cc
@@ -376,10 +376,10 @@ static void GetAllHeaders(JNIEnv* env,
if (headers == NULL)
return;
- void* iter = NULL;
+ size_t iter = 0;
std::string header_name;
std::string header_value;
- while (headers->EnumerateHeaderLines(&iter, &header_name, &header_value)) {
+ while (headers->EnumerateHeaderLines(iter, &header_name, &header_value)) {
ScopedJavaLocalRef<jstring> name =
ConvertUTF8ToJavaString(env, header_name);
ScopedJavaLocalRef<jstring> value =

Powered by Google App Engine
This is Rietveld 408576698