Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1669)

Unified Diff: chrome/browser/mod_pagespeed/mod_pagespeed_metrics.cc

Issue 1594973004: Remove use of void** from HttpResponseHeaders::EnumerateHeaderLines (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/mod_pagespeed/mod_pagespeed_metrics.cc
diff --git a/chrome/browser/mod_pagespeed/mod_pagespeed_metrics.cc b/chrome/browser/mod_pagespeed/mod_pagespeed_metrics.cc
index 6ef2d29b84e029cf44d86900f41e2868d6e100f4..f007a54b69f41e16a138bbf61d764e0799c9b847 100644
--- a/chrome/browser/mod_pagespeed/mod_pagespeed_metrics.cc
+++ b/chrome/browser/mod_pagespeed/mod_pagespeed_metrics.cc
@@ -86,10 +86,10 @@ void RecordMetrics(const content::ResourceType resource_type,
if (!response_headers)
return;
- void* iter = nullptr;
+ size_t iter = 0;
std::string name;
std::string value;
- while (response_headers->EnumerateHeaderLines(&iter, &name, &value)) {
+ while (response_headers->EnumerateHeaderLines(iter, &name, &value)) {
if (name == kModPagespeedHeader) {
// Bucket 1 counts occurrences of the X-Mod-Pagespeed header.
UMA_HISTOGRAM_ENUMERATION(kPagespeedServerHistogram,

Powered by Google App Engine
This is Rietveld 408576698