Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(793)

Issue 1594813002: Oilpan: Fix weak processing for IntersectionObserver::m_root (Closed)

Created:
4 years, 11 months ago by haraken
Modified:
4 years, 11 months ago
Reviewers:
sof, szager1
CC:
chromium-reviews, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Oilpan: Fix weak processing for IntersectionObserver::m_root This is a follow-up fix for https://codereview.chromium.org/1591763003/. IntersectionObserver::m_root must be cleared in the weak callback when the m_root is dead. BUG= Committed: https://crrev.com/2760f06a3c43c8919f4ecae43f460ada20d0990b Cr-Commit-Position: refs/heads/master@{#369956}

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -6 lines) Patch
M third_party/WebKit/Source/core/dom/IntersectionObserver.h View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/IntersectionObserver.cpp View 1 2 1 chunk +8 lines, -5 lines 0 comments Download

Messages

Total messages: 20 (7 generated)
haraken
PTAL
4 years, 11 months ago (2016-01-16 14:11:07 UTC) #2
sof
lgtm, thanks.
4 years, 11 months ago (2016-01-16 14:16:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1594813002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1594813002/1
4 years, 11 months ago (2016-01-16 14:17:02 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/146654)
4 years, 11 months ago (2016-01-16 14:20:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1594813002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1594813002/20001
4 years, 11 months ago (2016-01-16 14:24:41 UTC) #10
sof
https://codereview.chromium.org/1594813002/diff/20001/third_party/WebKit/Source/platform/heap/Heap.h File third_party/WebKit/Source/platform/heap/Heap.h (right): https://codereview.chromium.org/1594813002/diff/20001/third_party/WebKit/Source/platform/heap/Heap.h#newcode121 third_party/WebKit/Source/platform/heap/Heap.h:121: static inline bool isHeapObjectAlive(const WeakPtr<T>& ptr) Do we really ...
4 years, 11 months ago (2016-01-16 14:26:12 UTC) #11
haraken
Added #if ENABLE(OILPAN) to the call site.
4 years, 11 months ago (2016-01-16 14:28:59 UTC) #12
sof
On 2016/01/16 14:28:59, haraken wrote: > Added #if ENABLE(OILPAN) to the call site. lgtm, that ...
4 years, 11 months ago (2016-01-16 14:32:13 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1594813002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1594813002/40001
4 years, 11 months ago (2016-01-16 15:36:57 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 11 months ago (2016-01-16 16:26:01 UTC) #16
commit-bot: I haz the power
Failed to apply the patch.
4 years, 11 months ago (2016-01-16 16:26:16 UTC) #17
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/2760f06a3c43c8919f4ecae43f460ada20d0990b Cr-Commit-Position: refs/heads/master@{#369956}
4 years, 11 months ago (2016-01-16 16:26:51 UTC) #19
sof
4 years, 11 months ago (2016-01-17 21:25:38 UTC) #20
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1596333002/ by sigbjornf@opera.com.

The reason for reverting is: This and the parent change introduced some
failures,


https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Oilpan...

backing out for now..

Powered by Google App Engine
This is Rietveld 408576698