Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ReadableStreamOperations.cpp

Issue 1594653003: Move utilities for V8 extras functions into V8Binding.h (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/ReadableStreamOperations.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/ReadableStreamOperations.cpp b/third_party/WebKit/Source/bindings/core/v8/ReadableStreamOperations.cpp
index 44044ac545e9f341fd0dc0365fe3d8329f5504cc..6f9235ac777fdacc73a8057fac91b22eec3db352 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ReadableStreamOperations.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/ReadableStreamOperations.cpp
@@ -10,34 +10,13 @@
namespace blink {
-namespace {
-
-v8::MaybeLocal<v8::Value> call(ScriptState* scriptState, const char* name, size_t numArgs, v8::Local<v8::Value>* args)
-{
- v8::Isolate* isolate = scriptState->isolate();
- v8::Local<v8::Context> context = scriptState->context();
- v8::Local<v8::Value> undefined = v8::Undefined(isolate);
- v8::Local<v8::Value> functionValue = scriptState->getFromExtrasExports(name).v8Value();
- ASSERT(!functionValue.IsEmpty() && functionValue->IsFunction());
- v8::Local<v8::Function> function = functionValue.As<v8::Function>();
- return function->Call(context, undefined, numArgs, args);
-}
-
-template <size_t N>
-v8::MaybeLocal<v8::Value> call(ScriptState* scriptState, const char* name, v8::Local<v8::Value>(&args)[N])
-{
- return call(scriptState, name, N, args);
-}
-
-} // namespace
-
ScriptValue ReadableStreamOperations::getReader(ScriptState* scriptState, v8::Local<v8::Value> stream, ExceptionState& es)
{
ASSERT(isReadableStream(scriptState, stream));
v8::TryCatch block(scriptState->isolate());
v8::Local<v8::Value> args[] = { stream };
- ScriptValue result(scriptState, call(scriptState, "AcquireReadableStreamReader", args));
+ ScriptValue result(scriptState, v8CallExtra(scriptState, "AcquireReadableStreamReader", args));
if (block.HasCaught())
es.rethrowV8Exception(block.Exception());
return result;
@@ -49,7 +28,7 @@ bool ReadableStreamOperations::isReadableStream(ScriptState* scriptState, v8::Lo
return false;
v8::Local<v8::Value> args[] = { value };
- return v8CallOrCrash(call(scriptState, "IsReadableStream", args))->ToBoolean()->Value();
+ return v8CallExtraOrCrash(scriptState, "IsReadableStream", args)->ToBoolean()->Value();
}
bool ReadableStreamOperations::isDisturbed(ScriptState* scriptState, v8::Local<v8::Value> stream)
@@ -57,7 +36,7 @@ bool ReadableStreamOperations::isDisturbed(ScriptState* scriptState, v8::Local<v
ASSERT(isReadableStream(scriptState, stream));
v8::Local<v8::Value> args[] = { stream };
- return v8CallOrCrash(call(scriptState, "IsReadableStreamDisturbed", args))->ToBoolean()->Value();
+ return v8CallExtraOrCrash(scriptState, "IsReadableStreamDisturbed", args)->ToBoolean()->Value();
}
bool ReadableStreamOperations::isLocked(ScriptState* scriptState, v8::Local<v8::Value> stream)
@@ -65,7 +44,7 @@ bool ReadableStreamOperations::isLocked(ScriptState* scriptState, v8::Local<v8::
ASSERT(isReadableStream(scriptState, stream));
v8::Local<v8::Value> args[] = { stream };
- return v8CallOrCrash(call(scriptState, "IsReadableStreamLocked", args))->ToBoolean()->Value();
+ return v8CallExtraOrCrash(scriptState, "IsReadableStreamLocked", args)->ToBoolean()->Value();
}
bool ReadableStreamOperations::isReadableStreamReader(ScriptState* scriptState, v8::Local<v8::Value> value)
@@ -74,7 +53,7 @@ bool ReadableStreamOperations::isReadableStreamReader(ScriptState* scriptState,
return false;
v8::Local<v8::Value> args[] = { value };
- return v8CallOrCrash(call(scriptState, "IsReadableStreamReader", args))->ToBoolean()->Value();
+ return v8CallExtraOrCrash(scriptState, "IsReadableStreamReader", args)->ToBoolean()->Value();
}
ScriptPromise ReadableStreamOperations::read(ScriptState* scriptState, v8::Local<v8::Value> reader)
@@ -82,7 +61,7 @@ ScriptPromise ReadableStreamOperations::read(ScriptState* scriptState, v8::Local
ASSERT(isReadableStreamReader(scriptState, reader));
v8::Local<v8::Value> args[] = { reader };
- return ScriptPromise::cast(scriptState, v8CallOrCrash(call(scriptState, "ReadFromReadableStreamReader", args)));
+ return ScriptPromise::cast(scriptState, v8CallExtraOrCrash(scriptState, "ReadFromReadableStreamReader", args));
}
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698