Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1437)

Side by Side Diff: third_party/WebKit/Source/bindings/core/v8/ReadableStreamOperations.cpp

Issue 1594653003: Move utilities for V8 extras functions into V8Binding.h (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "bindings/core/v8/ReadableStreamOperations.h" 5 #include "bindings/core/v8/ReadableStreamOperations.h"
6 6
7 #include "bindings/core/v8/ExceptionState.h" 7 #include "bindings/core/v8/ExceptionState.h"
8 #include "bindings/core/v8/ScriptState.h" 8 #include "bindings/core/v8/ScriptState.h"
9 #include "bindings/core/v8/V8BindingMacros.h" 9 #include "bindings/core/v8/V8BindingMacros.h"
10 10
11 namespace blink { 11 namespace blink {
12 12
13 namespace {
14
15 v8::MaybeLocal<v8::Value> call(ScriptState* scriptState, const char* name, size_ t numArgs, v8::Local<v8::Value>* args)
16 {
17 v8::Isolate* isolate = scriptState->isolate();
18 v8::Local<v8::Context> context = scriptState->context();
19 v8::Local<v8::Value> undefined = v8::Undefined(isolate);
20 v8::Local<v8::Value> functionValue = scriptState->getFromExtrasExports(name) .v8Value();
21 ASSERT(!functionValue.IsEmpty() && functionValue->IsFunction());
22 v8::Local<v8::Function> function = functionValue.As<v8::Function>();
23 return function->Call(context, undefined, numArgs, args);
24 }
25
26 template <size_t N>
27 v8::MaybeLocal<v8::Value> call(ScriptState* scriptState, const char* name, v8::L ocal<v8::Value>(&args)[N])
28 {
29 return call(scriptState, name, N, args);
30 }
31
32 } // namespace
33
34 ScriptValue ReadableStreamOperations::getReader(ScriptState* scriptState, v8::Lo cal<v8::Value> stream, ExceptionState& es) 13 ScriptValue ReadableStreamOperations::getReader(ScriptState* scriptState, v8::Lo cal<v8::Value> stream, ExceptionState& es)
35 { 14 {
36 ASSERT(isReadableStream(scriptState, stream)); 15 ASSERT(isReadableStream(scriptState, stream));
37 16
38 v8::TryCatch block(scriptState->isolate()); 17 v8::TryCatch block(scriptState->isolate());
39 v8::Local<v8::Value> args[] = { stream }; 18 v8::Local<v8::Value> args[] = { stream };
40 ScriptValue result(scriptState, call(scriptState, "AcquireReadableStreamRead er", args)); 19 ScriptValue result(scriptState, v8CallExtra(scriptState, "AcquireReadableStr eamReader", args));
41 if (block.HasCaught()) 20 if (block.HasCaught())
42 es.rethrowV8Exception(block.Exception()); 21 es.rethrowV8Exception(block.Exception());
43 return result; 22 return result;
44 } 23 }
45 24
46 bool ReadableStreamOperations::isReadableStream(ScriptState* scriptState, v8::Lo cal<v8::Value> value) 25 bool ReadableStreamOperations::isReadableStream(ScriptState* scriptState, v8::Lo cal<v8::Value> value)
47 { 26 {
48 if (!value->IsObject()) 27 if (!value->IsObject())
49 return false; 28 return false;
50 29
51 v8::Local<v8::Value> args[] = { value }; 30 v8::Local<v8::Value> args[] = { value };
52 return v8CallOrCrash(call(scriptState, "IsReadableStream", args))->ToBoolean ()->Value(); 31 return v8CallExtraOrCrash(scriptState, "IsReadableStream", args)->ToBoolean( )->Value();
53 } 32 }
54 33
55 bool ReadableStreamOperations::isDisturbed(ScriptState* scriptState, v8::Local<v 8::Value> stream) 34 bool ReadableStreamOperations::isDisturbed(ScriptState* scriptState, v8::Local<v 8::Value> stream)
56 { 35 {
57 ASSERT(isReadableStream(scriptState, stream)); 36 ASSERT(isReadableStream(scriptState, stream));
58 37
59 v8::Local<v8::Value> args[] = { stream }; 38 v8::Local<v8::Value> args[] = { stream };
60 return v8CallOrCrash(call(scriptState, "IsReadableStreamDisturbed", args))-> ToBoolean()->Value(); 39 return v8CallExtraOrCrash(scriptState, "IsReadableStreamDisturbed", args)->T oBoolean()->Value();
61 } 40 }
62 41
63 bool ReadableStreamOperations::isLocked(ScriptState* scriptState, v8::Local<v8:: Value> stream) 42 bool ReadableStreamOperations::isLocked(ScriptState* scriptState, v8::Local<v8:: Value> stream)
64 { 43 {
65 ASSERT(isReadableStream(scriptState, stream)); 44 ASSERT(isReadableStream(scriptState, stream));
66 45
67 v8::Local<v8::Value> args[] = { stream }; 46 v8::Local<v8::Value> args[] = { stream };
68 return v8CallOrCrash(call(scriptState, "IsReadableStreamLocked", args))->ToB oolean()->Value(); 47 return v8CallExtraOrCrash(scriptState, "IsReadableStreamLocked", args)->ToBo olean()->Value();
69 } 48 }
70 49
71 bool ReadableStreamOperations::isReadableStreamReader(ScriptState* scriptState, v8::Local<v8::Value> value) 50 bool ReadableStreamOperations::isReadableStreamReader(ScriptState* scriptState, v8::Local<v8::Value> value)
72 { 51 {
73 if (!value->IsObject()) 52 if (!value->IsObject())
74 return false; 53 return false;
75 54
76 v8::Local<v8::Value> args[] = { value }; 55 v8::Local<v8::Value> args[] = { value };
77 return v8CallOrCrash(call(scriptState, "IsReadableStreamReader", args))->ToB oolean()->Value(); 56 return v8CallExtraOrCrash(scriptState, "IsReadableStreamReader", args)->ToBo olean()->Value();
78 } 57 }
79 58
80 ScriptPromise ReadableStreamOperations::read(ScriptState* scriptState, v8::Local <v8::Value> reader) 59 ScriptPromise ReadableStreamOperations::read(ScriptState* scriptState, v8::Local <v8::Value> reader)
81 { 60 {
82 ASSERT(isReadableStreamReader(scriptState, reader)); 61 ASSERT(isReadableStreamReader(scriptState, reader));
83 62
84 v8::Local<v8::Value> args[] = { reader }; 63 v8::Local<v8::Value> args[] = { reader };
85 return ScriptPromise::cast(scriptState, v8CallOrCrash(call(scriptState, "Rea dFromReadableStreamReader", args))); 64 return ScriptPromise::cast(scriptState, v8CallExtraOrCrash(scriptState, "Rea dFromReadableStreamReader", args));
86 } 65 }
87 66
88 } // namespace blink 67 } // namespace blink
89 68
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698