Move utilities for V8 extras functions into V8Binding.h

Move utilities for V8 extras functions into V8BindingMacros.h

These were previously only used inside ReadableStreamOperations.cpp, but a subsequent commit will need them in other files as well.

While doing so, change them to use V8ScriptRunner::callFunction instead of calling directly.

BUG=
R=haraken@chromium.org,yhirano@chromium.org

Committed: https://crrev.com/68f232928d36dbabad0ff44583873c63ef169e96
Cr-Commit-Position: refs/heads/master@{#370273}

[haraken, 2016-01-16 03:54:31]

https://codereview.chromium.org/1594653003/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/bindings/core/v8/V8BindingMacros.h (right):

https://codereview.chromium.org/1594653003/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/core/v8/V8BindingMacros.h:119: return
function->Call(context, undefined, numArgs, args);

We want to unify all Function::Calls into V8ScriptRunner::callFunction, which
already takes care of ScriptForbiddenScope, recursion scopes, inspector
instrumentation, tracing etc.

[yhirano, 2016-01-17 23:59:55]

https://codereview.chromium.org/1594653003/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/bindings/core/v8/V8BindingMacros.h (right):

https://codereview.chromium.org/1594653003/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/core/v8/V8BindingMacros.h:35: #include
"bindings/core/v8/ScriptValue.h"
Not used?

[domenic, 2016-01-19 21:41:00]

https://codereview.chromium.org/1594653003/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/bindings/core/v8/V8BindingMacros.h (right):

https://codereview.chromium.org/1594653003/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/core/v8/V8BindingMacros.h:35: #include
"bindings/core/v8/ScriptValue.h"
On 2016/01/17 at 23:59:55, yhirano wrote:
> Not used?

It turns out getExtrasExports returns a ScriptValue so it is used. I tried to
move it to ScriptState.h but then it is circular. I'm not sure if there's a
better option.

https://codereview.chromium.org/1594653003/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/core/v8/V8BindingMacros.h:119: return
function->Call(context, undefined, numArgs, args);
On 2016/01/16 at 03:54:31, haraken wrote:
> We want to unify all Function::Calls into V8ScriptRunner::callFunction, which
already takes care of ScriptForbiddenScope, recursion scopes, inspector
instrumentation, tracing etc.

Done; PTAL.

[haraken, 2016-01-19 21:49:48]

LGTM with one comment.

https://codereview.chromium.org/1594653003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/bindings/core/v8/V8BindingMacros.h (right):

https://codereview.chromium.org/1594653003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/core/v8/V8BindingMacros.h:36: #include
"bindings/core/v8/V8ScriptRunner.h"

Hmm, V8BindingMacros.h is intended to be a collection of simple macros that
don't need to include other binding headers. (I was a bit surprised that
including these headers doesn't cause #include cycles :-)

Given that v8CallExtra is complicated enough, would you move it to V8Binding.h?

[domenic, 2016-01-19 22:38:52]

Description was changed from

==========
Move utilities for V8 extras functions into V8BindingMacros.h

These were previously only used inside ReadableStreamOperations.cpp, but a
subsequent commit will need them in other files as well.

BUG=
R=haraken@chromium.org,yhirano@chromium.org
==========

to

==========
Move utilities for V8 extras functions into V8BindingMacros.h

These were previously only used inside ReadableStreamOperations.cpp, but a
subsequent commit will need them in other files as well.

While doing so, change them to use V8ScriptRunner::callFunction instead of
calling directly.

BUG=
R=haraken@chromium.org,yhirano@chromium.org
==========

[domenic, 2016-01-19 22:39:31]

On 2016/01/19 at 21:49:48, haraken wrote:
> LGTM with one comment.
> 
>
https://codereview.chromium.org/1594653003/diff/20001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/bindings/core/v8/V8BindingMacros.h (right):
> 
>
https://codereview.chromium.org/1594653003/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/bindings/core/v8/V8BindingMacros.h:36: #include
"bindings/core/v8/V8ScriptRunner.h"
> 
> Hmm, V8BindingMacros.h is intended to be a collection of simple macros that
don't need to include other binding headers. (I was a bit surprised that
including these headers doesn't cause #include cycles :-)
> 
> Given that v8CallExtra is complicated enough, would you move it to
V8Binding.h?

Done.

[domenic, 2016-01-19 22:39:35]

The CQ bit was checked by domenic@chromium.org

[domenic, 2016-01-19 22:39:35]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/1594653003/#ps40001
(title: "Move to V8Binding.h and fix tests")

[commit-bot: I haz the power, 2016-01-19 22:40:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1594653003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1594653003/40001

[domenic, 2016-01-19 22:44:13]

The CQ bit was unchecked by domenic@chromium.org

[domenic, 2016-01-19 22:44:33]

On 2016/01/19 at 22:40:39, commit-bot wrote:
> CQ is trying da patch. Follow status at
>  https://chromium-cq-status.appspot.com/patch-status/1594653003/40001
> View timeline at
>  https://chromium-cq-status.appspot.com/patch-timeline/1594653003/40001

Sorry, I didn't mean to commit before yhirano@ gave a l-g-t-m.

[yhirano, 2016-01-20 01:30:57]

lgtm

[domenic, 2016-01-20 01:36:42]

The CQ bit was checked by domenic@chromium.org

[commit-bot: I haz the power, 2016-01-20 01:38:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1594653003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1594653003/40001

[commit-bot: I haz the power, 2016-01-20 01:47:07]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-01-20 01:49:26]

Description was changed from

==========
Move utilities for V8 extras functions into V8BindingMacros.h

These were previously only used inside ReadableStreamOperations.cpp, but a
subsequent commit will need them in other files as well.

While doing so, change them to use V8ScriptRunner::callFunction instead of
calling directly.

BUG=
R=haraken@chromium.org,yhirano@chromium.org
==========

to

==========
Move utilities for V8 extras functions into V8BindingMacros.h

These were previously only used inside ReadableStreamOperations.cpp, but a
subsequent commit will need them in other files as well.

While doing so, change them to use V8ScriptRunner::callFunction instead of
calling directly.

BUG=
R=haraken@chromium.org,yhirano@chromium.org

Committed: https://crrev.com/68f232928d36dbabad0ff44583873c63ef169e96
Cr-Commit-Position: refs/heads/master@{#370273}
==========

[commit-bot: I haz the power, 2016-01-20 01:49:26]

Patchset 3 (id:??) landed as
https://crrev.com/68f232928d36dbabad0ff44583873c63ef169e96
Cr-Commit-Position: refs/heads/master@{#370273}