Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ReadableStreamOperationsTest.cpp

Issue 1594653003: Move utilities for V8 extras functions into V8Binding.h (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Move to V8Binding.h and fix tests Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/ReadableStreamOperationsTest.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/ReadableStreamOperationsTest.cpp b/third_party/WebKit/Source/bindings/core/v8/ReadableStreamOperationsTest.cpp
index 0339a605dbd179b96c5c6349f822fefbaef88387..2693c75ab7646b25019cbd8959dfcc99770ed9a3 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ReadableStreamOperationsTest.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/ReadableStreamOperationsTest.cpp
@@ -12,6 +12,7 @@
#include "bindings/core/v8/V8BindingMacros.h"
#include "bindings/core/v8/V8IteratorResultValue.h"
#include "bindings/core/v8/V8ThrowException.h"
+#include "core/dom/Document.h"
#include "platform/heap/Handle.h"
#include "testing/gtest/include/gtest/gtest.h"
#include <v8.h>
@@ -110,7 +111,13 @@ private:
class ReadableStreamOperationsTest : public ::testing::Test {
public:
- ReadableStreamOperationsTest() : m_scope(v8::Isolate::GetCurrent()), m_block(isolate()) {}
+ ReadableStreamOperationsTest()
+ : m_scope(v8::Isolate::GetCurrent())
+ , m_block(isolate())
+ , m_document(Document::create())
+ {
+ scriptState()->setExecutionContext(m_document.get());
+ }
~ReadableStreamOperationsTest() override
{
// Execute all pending microtasks
@@ -148,6 +155,7 @@ public:
V8TestingScope m_scope;
v8::TryCatch m_block;
+ RefPtrWillBePersistent<Document> m_document;
};
TEST_F(ReadableStreamOperationsTest, IsReadableStream)

Powered by Google App Engine
This is Rietveld 408576698