Modify kilobench to run each sample in its own process

Modify kilobench to run each sample in its own process

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1594553003

Committed: https://skia.googlesource.com/skia/+/98eb3d3776ba64099a19c92ab7aac4f2e323d857

[joshua.litt, 2016-01-15 15:02:10]

Description was changed from

==========
Modify kilobench to run each sample in its own process

BUG=skia:
==========

to

==========
Modify kilobench to run each sample in its own process

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[joshualitt, 2016-01-15 15:04:10]

joshualitt@google.com changed reviewers:
+ bsalomon@google.com, djsollen@google.com, joshualitt@google.com,
mtklein@google.com

[djsollen, 2016-01-15 16:36:05]

https://codereview.chromium.org/1594553003/diff/20001/tools/kilobench/kiloben...
File tools/kilobench/kilobench.cpp (right):

https://codereview.chromium.org/1594553003/diff/20001/tools/kilobench/kiloben...
tools/kilobench/kilobench.cpp:413: if (childPid) {
shouldn't this be !childPid?

[joshualitt, 2016-01-15 18:07:16]

On 2016/01/15 16:36:05, djsollen wrote:
>
https://codereview.chromium.org/1594553003/diff/20001/tools/kilobench/kiloben...
> File tools/kilobench/kilobench.cpp (right):
> 
>
https://codereview.chromium.org/1594553003/diff/20001/tools/kilobench/kiloben...
> tools/kilobench/kilobench.cpp:413: if (childPid) {
> shouldn't this be !childPid?

cl updated to handle fork failing

[djsollen, 2016-01-15 18:19:45]

lgtm

[joshualitt, 2016-01-15 19:39:51]

The CQ bit was checked by joshualitt@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-01-15 19:39:56]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1594553003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1594553003/40001

[commit-bot: I haz the power, 2016-01-15 19:42:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-15 19:42:16]

Dry run: Try jobs failed on following builders:
  Build-Ubuntu-GCC-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86...)

[joshualitt, 2016-01-15 19:52:10]

The CQ bit was checked by joshualitt@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-01-15 19:52:18]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1594553003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1594553003/60001

[commit-bot: I haz the power, 2016-01-15 20:04:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-15 20:04:17]

Dry run: This issue passed the CQ dry run.

[joshualitt, 2016-01-15 20:06:56]

The CQ bit was checked by joshualitt@google.com

[joshualitt, 2016-01-15 20:06:57]

The patchset sent to the CQ was uploaded after l-g-t-m from djsollen@google.com
Link to the patchset: https://codereview.chromium.org/1594553003/#ps60001
(title: "check return values of pipe, read, write")

[commit-bot: I haz the power, 2016-01-15 20:07:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1594553003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1594553003/60001

[commit-bot: I haz the power, 2016-01-15 20:07:41]

Description was changed from

==========
Modify kilobench to run each sample in its own process

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Modify kilobench to run each sample in its own process

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/98eb3d3776ba64099a19c92ab7aac4f2e323d857
==========

[commit-bot: I haz the power, 2016-01-15 20:07:42]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/98eb3d3776ba64099a19c92ab7aac4f2e323d857