Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 1581153006: Now Kilobench times, exact same timing mechanism as nanobench (Closed)

Created:
4 years, 11 months ago by joshua.litt
Modified:
4 years, 11 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@kilobench-1-carveitout
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : add ability to sanity dump images #

Patch Set 3 : tidy #

Unified diffs Side-by-side diffs Delta from patch set Stats (+287 lines, -4 lines) Patch
M gyp/kilobench.gyp View 1 chunk +4 lines, -2 lines 0 comments Download
M tools/kilobench/kilobench.cpp View 1 2 4 chunks +283 lines, -2 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 12 (6 generated)
joshualitt
In this CL I stole all the timing code from nanobench. If we actually decide ...
4 years, 11 months ago (2016-01-14 19:55:30 UTC) #3
djsollen
lgtm
4 years, 11 months ago (2016-01-15 16:45:09 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1581153006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1581153006/40001
4 years, 11 months ago (2016-01-15 16:55:46 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-15 17:06:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1581153006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1581153006/40001
4 years, 11 months ago (2016-01-15 17:59:32 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2016-01-15 18:00:13 UTC) #12
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/eb60d671201cd88a1231eb22dbb637fe31ea76d8

Powered by Google App Engine
This is Rietveld 408576698