Remove more ifdefs and TODOs that were added for Aura Android

Remove more ifdefs and TODOs that were for Aura Android

All of them were introduced in codereview.chromium.org/1403293003.
As we no longer need to support Aura Android at this moment, removing
them from code base.


BUG=507792

[bshe, 2016-01-18 14:36:44]

bshe@chromium.org changed reviewers:
+ sky@chromium.org

[bshe, 2016-01-18 14:36:44]

Hi Scott.
Do you mind to take a look at this simple CL? It removes some of the ifdefs and
TODOs that no longer needed.
Thanks!

Biao

[sky, 2016-01-19 17:05:20]

https://codereview.chromium.org/1594403003/diff/1/ui/views/widget/android/nat...
File ui/views/widget/android/native_widget_android.cc (right):

https://codereview.chromium.org/1594403003/diff/1/ui/views/widget/android/nat...
ui/views/widget/android/native_widget_android.cc:753: int
NativeWidgetAndroid::OnPerformDrop(const ui::DropTargetEvent& event) {
Should we remove this file entirely?

[bshe, 2016-01-20 21:59:02]

bshe@chromium.org changed reviewers:
+ mfomitchev@chromium.org

[bshe, 2016-01-20 21:59:03]

Thanks for reviewing.
I dont mind to remove the file. But I remember mfomitchev@ said that we may use
the file in the future. +mfomitchev to confirm.

[mfomitchev, 2016-01-21 16:43:38]

Description was changed from

==========
Remove more ifdefs and TODOs that were for Aura Android

All of them were introduced in codereview.chromium.org/1403293003.
As we no longer need to support Aura Android at this moment, removing
them from code base.


BUG=507792
==========

to

==========
Remove more ifdefs and TODOs that were for Aura Android

All of them were introduced in codereview.chromium.org/1403293003.
As we no longer need to support Aura Android at this moment, removing
them from code base.


BUG=507792
==========

[mfomitchev, 2016-01-21 16:43:38]

mfomitchev@chromium.org changed reviewers:
+ sievers@chromium.org

[mfomitchev, 2016-01-21 16:43:56]

For chrome we removed the code entirely. For content and below we took the
approach of leaving the code, but removing the TODOs. The reasoning was that
it's still possible that Clank team will use Aura in the future to render the
tab strip. It's not a great reason since the likelihood of that is pretty low.
However the cost of leaving a couple of extra classes around seemed pretty low
as well. I don't have a strong opinion on this either way.

[sky, 2016-01-21 20:08:21]

In general we don't keep dead code around. Imagine if every engineer
kept dead code around, the cost gets high for refactor and general
maintenance. If we decide we need this code in the future we can bring
it back from history.

  -Scott

On Thu, Jan 21, 2016 at 8:43 AM,  <mfomitchev@chromium.org> wrote:
> For chrome we removed the code entirely. For content and below we took the
> approach of leaving the code, but removing the TODOs. The reasoning was that
> it's still possible that Clank team will use Aura in the future to render
> the
> tab strip. It's not a great reason since the likelihood of that is pretty
> low.
> However the cost of leaving a couple of extra classes around seemed pretty
> low
> as well. I don't have a strong opinion on this either way.
>
> https://codereview.chromium.org/1594403003/

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[mfomitchev, 2016-01-21 22:07:25]

Would any of these Android Aura changes in content and below be useful for
Mandoline? I am assuming Mandoline isn't completely dead, and a lot of the early
changes for it (which are still in TOT) were also about getting Android Aura
working.

[sky, 2016-01-21 22:29:38]

Mandoline isn't completely dead, but getting it going on aura is not a
priority right now. Best to nuke it all for now. If mandoline and/or
aura on android becomes a priority we can bring the code back.

  -Scott

On Thu, Jan 21, 2016 at 2:07 PM,  <mfomitchev@chromium.org> wrote:
> Would any of these Android Aura changes in content and below be useful for
> Mandoline? I am assuming Mandoline isn't completely dead, and a lot of the
> early
> changes for it (which are still in TOT) were also about getting Android Aura
> working.
>
> https://codereview.chromium.org/1594403003/

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[bshe, 2016-01-22 17:12:29]

On 2016/01/21 22:29:38, sky wrote:
> Mandoline isn't completely dead, but getting it going on aura is not a
> priority right now. Best to nuke it all for now. If mandoline and/or
> aura on android becomes a priority we can bring the code back.
> 
>   -Scott
> 
> On Thu, Jan 21, 2016 at 2:07 PM,  <mailto:mfomitchev@chromium.org> wrote:
> > Would any of these Android Aura changes in content and below be useful for
> > Mandoline? I am assuming Mandoline isn't completely dead, and a lot of the
> > early
> > changes for it (which are still in TOT) were also about getting Android Aura
> > working.
> >
> > https://codereview.chromium.org/1594403003/
> 
> -- 
> You received this message because you are subscribed to the Google Groups
> "Chromium-reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.
> 

Close this issue without upstream. A revert of the original CL will be created.

[mfomitchev, 2016-01-26 22:12:09]

Created https://codereview.chromium.org/1639003002/ to do the full revert.