Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Unified Diff: third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp

Issue 1593763002: Keep AudioSourceNode from premature GC with ScriptWrappable::hasPendingActivity() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added [DependentLifetime] Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp
diff --git a/third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp b/third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp
index 0dceaa90165c3a8b09ab9765a3bb3ef32369de66..85a48e08782cf8caff755cc632a5902958610d37 100644
--- a/third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp
+++ b/third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp
@@ -689,22 +689,22 @@ void AudioBufferSourceNode::setLoopEnd(double loopEnd)
audioBufferSourceHandler().setLoopEnd(loopEnd);
}
-void AudioBufferSourceNode::start(ExceptionState& exceptionState)
+void AudioBufferSourceNode::startNode(ExceptionState& exceptionState)
{
audioBufferSourceHandler().start(0, exceptionState);
}
-void AudioBufferSourceNode::start(double when, ExceptionState& exceptionState)
+void AudioBufferSourceNode::startNode(double when, ExceptionState& exceptionState)
{
audioBufferSourceHandler().start(when, exceptionState);
}
-void AudioBufferSourceNode::start(double when, double grainOffset, ExceptionState& exceptionState)
+void AudioBufferSourceNode::startNode(double when, double grainOffset, ExceptionState& exceptionState)
{
audioBufferSourceHandler().start(when, grainOffset, exceptionState);
}
-void AudioBufferSourceNode::start(double when, double grainOffset, double grainDuration, ExceptionState& exceptionState)
+void AudioBufferSourceNode::startNode(double when, double grainOffset, double grainDuration, ExceptionState& exceptionState)
{
audioBufferSourceHandler().start(when, grainOffset, grainDuration, exceptionState);
}

Powered by Google App Engine
This is Rietveld 408576698