third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.idl - Issue 1593763002: Keep AudioSourceNode from premature GC with ScriptWrappable::hasPendingActivity()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.idl

Issue 1593763002: Keep AudioSourceNode from premature GC with ScriptWrappable::hasPendingActivity() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Simplify changes (-AbstractAudioContext) Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/webaudio/audiosource-premature-gc.html ('K') | « third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp ('k') | third_party/WebKit/Source/modules/webaudio/AudioScheduledSourceNode.h » ('j') | third_party/WebKit/Source/modules/webaudio/AudioScheduledSourceNode.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.idl

diff --git a/third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.idl b/third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.idl

index 3daec8c17a3862555db48fcbbb59d1f2a4f8b0fd..eea7f7a69bbea0d63328e81644ddc4f97fea0660 100644

--- a/third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.idl

+++ b/third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.idl

@@ -33,8 +33,8 @@ interface AudioBufferSourceNode : AudioSourceNode {

attribute double loopStart;

attribute double loopEnd;

- [RaisesException] void start(optional double when, optional double grainOffset, optional double grainDuration);

- [RaisesException] void stop(optional double when);

+ [RaisesException, ImplementedAs=startNode] void start(optional double when, optional double grainOffset, optional double grainDuration);

+ [RaisesException, ImplementedAs=stopNode] void stop(optional double when);

Raymond Toy 2016/02/22 17:43:51 Why are these methods renamed?

hongchan 2016/02/23 18:01:33 Oh, I will fix this, but it was because ActiveDOMO

attribute EventHandler onended;

};