third_party/WebKit/Source/modules/webaudio/AudioScheduledSourceNode.h - Issue 1593763002: Keep AudioSourceNode from premature GC with ScriptWrappable::hasPendingActivity()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webaudio/AudioScheduledSourceNode.h

Issue 1593763002: Keep AudioSourceNode from premature GC with ScriptWrappable::hasPendingActivity() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Simplify changes (-AbstractAudioContext) Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.idl ('K') | « third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.idl ('k') | third_party/WebKit/Source/modules/webaudio/AudioScheduledSourceNode.cpp » ('j') | third_party/WebKit/Source/modules/webaudio/AudioScheduledSourceNode.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webaudio/AudioScheduledSourceNode.h

diff --git a/third_party/WebKit/Source/modules/webaudio/AudioScheduledSourceNode.h b/third_party/WebKit/Source/modules/webaudio/AudioScheduledSourceNode.h

index ed6a5300de45d6b370c3d958f7d13e75e6beef13..e2c1b988450b8e3bfdd1ff94b312d4f047cb8438 100644

--- a/third_party/WebKit/Source/modules/webaudio/AudioScheduledSourceNode.h

+++ b/third_party/WebKit/Source/modules/webaudio/AudioScheduledSourceNode.h

@@ -122,14 +122,17 @@ private:

class AudioScheduledSourceNode : public AudioSourceNode {

public:

- void start(ExceptionState&);

- void start(double when, ExceptionState&);

- void stop(ExceptionState&);

- void stop(double when, ExceptionState&);

+ void startNode(ExceptionState&);

+ void startNode(double when, ExceptionState&);

+ void stopNode(ExceptionState&);

+ void stopNode(double when, ExceptionState&);

EventListener* onended();

void setOnended(PassRefPtrWillBeRawPtr<EventListener>);

+ // ScriptWrappable

+ bool hasPendingActivity() const final;

protected:

explicit AudioScheduledSourceNode(AbstractAudioContext&);

AudioScheduledSourceHandler& audioScheduledSourceHandler() const;