This CL adds methods to manipulate RTP header extension, particularly

content/browser/renderer_host/p2p/socket_host.h

Index: content/browser/renderer_host/p2p/socket_host.h
diff --git a/content/browser/renderer_host/p2p/socket_host.h b/content/browser/renderer_host/p2p/socket_host.h
index 24e49bdccd098c9d4ecc9f1448f80738bf15eb4f..2be075f402565dc3a7eeae365c7c71db64d35413 100644
--- a/content/browser/renderer_host/p2p/socket_host.h
+++ b/content/browser/renderer_host/p2p/socket_host.h
@@ -18,9 +18,23 @@ namespace net {
 class URLRequestContextGetter;
 }
 
+namespace talk_base {
+struct PacketOptions;
+}
+
 namespace content {
 class P2PMessageThrottler;
 
+namespace packet_processing_helpers {
+void MaybeUpdatePacketAbsSendTimeExtn(char* data, int length,

[Solis, 2014/03/03 10:22:29]

Why aren't there any tests for this function?

[Mallinath (Gone from Chromium), 2014/03/04 00:15:46]

I am not sure how can I test this method in particular. As we can't test any
thing deterministically in this method. Both timestamp and HMAC will vary.
That's why I had to expose below two methods and test those instead. As you can
see the major change is around parsing of the packet. 

On 2014/03/03 10:22:29, Solis wrote:

[Solis, 2014/03/04 09:53:24]

1. There's logic in the function which isn't that straightforward. This should
be verified.
2. The function to update the auth tag is currently untested.

One strategy for testing would be to feed this function with the same packets
you have for the other tests and compare the output to some expected result
(should you decide to do this, I would suggest creating a helper
macro/function/template).

Another strategy is to expose the auth tag update function here so it can be
tested separately.

On 2014/03/04 00:15:46, mallinath2 wrote:

[Mallinath (Gone from Chromium), 2014/03/06 07:39:43]

I added test cases for MaybeUpdatePacketAbsSendTimeExtn which also verifies auth
tag function.

On 2014/03/04 09:53:24, Solis wrote:

+                                      const talk_base::PacketOptions& options);
+bool GetRtpPacketStartPositionAndLength(char* data, int length,
+                                        int* rtp_start_pos,
+                                        int* rtp_packet_length);
+bool MaybeUpdateRtpAbsSendTimeExtn(char* rtp, int length,
+                                   int extension_id);
+}  // packet_processing_helpers
+
 // Base class for P2P sockets.
 class CONTENT_EXPORT P2PSocketHost {
  public:
@@ -49,7 +63,6 @@ class CONTENT_EXPORT P2PSocketHost {
   virtual bool SetOption(P2PSocketOption option, int value) = 0;
 
  protected:
-  friend class P2PSocketHostTcpTestBase;
 
   // TODO(mallinath) - Remove this below enum and use one defined in
   // libjingle/souce/talk/p2p/base/stun.h