This CL adds methods to manipulate RTP header extension, particularly

content/browser/renderer_host/p2p/socket_host.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_RENDERER_HOST_P2P_SOCKET_HOST_H_
 #define CONTENT_BROWSER_RENDERER_HOST_P2P_SOCKET_HOST_H_
 
 #include "content/common/content_export.h"
 #include "content/common/p2p_socket_type.h"
 #include "net/base/ip_endpoint.h"
 #include "net/udp/datagram_socket.h"
 
 namespace IPC {
 class Sender;
 }
 
 namespace net {
 class URLRequestContextGetter;
 }
 
+namespace talk_base {
+struct PacketOptions;
+}
+
 namespace content {
 class P2PMessageThrottler;
 
+namespace packet_processing_helpers {
+void MaybeUpdatePacketAbsSendTimeExtn(char* data, int length,

[Solis, 2014/03/03 10:22:29]

Why aren't there any tests for this function?

[Mallinath (Gone from Chromium), 2014/03/04 00:15:46]

I am not sure how can I test this method in particular. As we can't test any
thing deterministically in this method. Both timestamp and HMAC will vary.
That's why I had to expose below two methods and test those instead. As you can
see the major change is around parsing of the packet. 

On 2014/03/03 10:22:29, Solis wrote:

[Solis, 2014/03/04 09:53:24]

1. There's logic in the function which isn't that straightforward. This should
be verified.
2. The function to update the auth tag is currently untested.

One strategy for testing would be to feed this function with the same packets
you have for the other tests and compare the output to some expected result
(should you decide to do this, I would suggest creating a helper
macro/function/template).

Another strategy is to expose the auth tag update function here so it can be
tested separately.

On 2014/03/04 00:15:46, mallinath2 wrote:

[Mallinath (Gone from Chromium), 2014/03/06 07:39:43]

I added test cases for MaybeUpdatePacketAbsSendTimeExtn which also verifies auth
tag function.

On 2014/03/04 09:53:24, Solis wrote:

+                                      const talk_base::PacketOptions& options);
+bool GetRtpPacketStartPositionAndLength(char* data, int length,
+                                        int* rtp_start_pos,
+                                        int* rtp_packet_length);
+bool MaybeUpdateRtpAbsSendTimeExtn(char* rtp, int length,
+                                   int extension_id);
+}  // packet_processing_helpers
+
 // Base class for P2P sockets.
 class CONTENT_EXPORT P2PSocketHost {
  public:
   static const int kStunHeaderSize = 20;
   // Creates P2PSocketHost of the specific type.
   static P2PSocketHost* Create(IPC::Sender* message_sender,
                                int id, P2PSocketType type,
                                net::URLRequestContextGetter* url_context,
                                P2PMessageThrottler* throttler);
 
   virtual ~P2PSocketHost();
 
   // Initalizes the socket. Returns false when initiazations fails.
   virtual bool Init(const net::IPEndPoint& local_address,
                     const net::IPEndPoint& remote_address) = 0;
 
   // Sends |data| on the socket to |to|.
   virtual void Send(const net::IPEndPoint& to,
                     const std::vector<char>& data,
                     net::DiffServCodePoint dscp,
                     uint64 packet_id) = 0;
 
   virtual P2PSocketHost* AcceptIncomingTcpConnection(
       const net::IPEndPoint& remote_address, int id) = 0;
 
   virtual bool SetOption(P2PSocketOption option, int value) = 0;
 
  protected:
-  friend class P2PSocketHostTcpTestBase;
 
   // TODO(mallinath) - Remove this below enum and use one defined in
   // libjingle/souce/talk/p2p/base/stun.h
   enum StunMessageType {
     STUN_BINDING_REQUEST = 0x0001,
     STUN_BINDING_RESPONSE = 0x0101,
     STUN_BINDING_ERROR_RESPONSE = 0x0111,
     STUN_SHARED_SECRET_REQUEST = 0x0002,
     STUN_SHARED_SECRET_RESPONSE = 0x0102,
     STUN_SHARED_SECRET_ERROR_RESPONSE = 0x0112,
@@ skipping 33 matching lines @@
   IPC::Sender* message_sender_;
   int id_;
   State state_;
 
   DISALLOW_COPY_AND_ASSIGN(P2PSocketHost);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_RENDERER_HOST_P2P_SOCKET_HOST_H_