Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 15934004: Revert 202339 "Better workaround for extension browser test prob..." (Closed)

Created:
7 years, 7 months ago by xiyuan
Modified:
7 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 202339 "Better workaround for extension browser test prob..." > Better workaround for extension browser test problems on win debug bots > > Instead of trying to fake out gtest output and exiting, just return true > in RunExtensionSubTest. > > TBR=shess@chromium.org,mpcomplete@chromium.org > > BUG=177163 > > Review URL: https://chromiumcodereview.appspot.com/16058002 TBR=asargent@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202347

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -42 lines) Patch
M trunk/src/chrome/browser/extensions/api/cloud_print_private/cloud_print_private_apitest.cc View 1 chunk +1 line, -8 lines 0 comments Download
M trunk/src/chrome/browser/extensions/api/webstore_private/webstore_private_apitest.cc View 5 chunks +19 lines, -23 lines 0 comments Download
M trunk/src/chrome/browser/extensions/extension_apitest.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/prerender/prerender_browsertest.cc View 1 chunk +1 line, -8 lines 0 comments Download
M trunk/src/chrome/test/data/extensions/api_test/webstore_private/theme.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
xiyuan
7 years, 7 months ago (2013-05-26 04:18:58 UTC) #1
xiyuan
Failed on multiple win bots: http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%28dbg%29%283%29/builds/35851 http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%28dbg%29%285%29/builds/30093 TabCaptureApiTest.ActiveTabPermission: [3044:1112:0525/210904:2319375:WARNING:extension_apitest.cc(169)] Workaround for 177163, prematurely returning [3044:1112:0525/210907:2322390:ERROR:textfield.h(168)] ...
7 years, 7 months ago (2013-05-26 04:21:31 UTC) #2
xiyuan
Committed patchset #1 manually as r202347.
7 years, 7 months ago (2013-05-26 04:21:53 UTC) #3
xiyuan
7 years, 7 months ago (2013-05-26 05:03:20 UTC) #4
Message was sent while issue was closed.
Some error other than time out.
http://build.chromium.org/p/chromium.win/builders/Win%20Aura%20Tests%20%283%2...

WebNavigationApiTest.RequestOpenTab: 
HTTP server started on 127.0.0.1:51947...
sending server_data: {"host": "127.0.0.1", "port": 51947} (36 bytes)
[2992:4364:0525/215248:4103497:ERROR:component_loader.cc(118)] Failed to parse
extension manifest.
[2992:4364:0525/215248:4103637:ERROR:chrome_views_delegate.cc(157)] NOT
IMPLEMENTED
[2992:4364:0525/215248:4103637:ERROR:desktop_root_window_host_win.cc(696)] NOT
IMPLEMENTED
[4624:1580:0525/215249:ERROR:dxva_video_decode_accelerator.cc(396)]
Direct3DCreate9Ex failed, HRESULT: 0x8876086a
[4624:1580:0525/215249:ERROR:dxva_video_decode_accelerator.cc(389)] Failed to
initialize D3D device and manager
[4308:4108:0525/215249:ERROR:power_monitor_win.cc(33)] Cannot create windows on
non-UI thread, power monitor disabled!
[4624:1580:0525/215250:ERROR:gl_surface_egl.cc(108)] eglInitialize failed with
error UNKNOWN
[4624:1580:0525/215250:ERROR:gl_surface_win.cc(54)]
GLSurfaceEGL::InitializeOneOff failed.
[2992:4364:0525/215250:4105493:WARNING:extension_apitest.cc(169)] Workaround for
177163, prematurely returning
Backtrace:
GURL::SchemeIs [0x08505722+18]
extensions::Extension::GetResourceURL [0x02EC3ED6+102]
extensions::Extension::GetResourceURL [0x00631B34+52]
extensions::WebNavigationApiTest_RequestOpenTab_Test::RunTestOnMainThread
[0x0086E5F7+663]
InProcessBrowserTest::RunTestOnMainThreadLoop [0x011D08C2+306]
content::BrowserTestBase::ProxyRunTestOnMainThreadLoop [0x01A8AADE+30]
base::internal::RunnableAdapter<void (__thiscall
content::BrowserTestBase::*)(void)>::Run [0x01A8B85B+27]
base::internal::InvokeHelper<0,void,base::internal::RunnableAdapter<void
(__thiscall content::BrowserTestBase::*)(void)>,void
__cdecl(content::BrowserTestBase * const &)>::MakeItSo [0x01A8B7FA+26]
base::internal::Invoker<1,base::internal::BindState<base::internal::RunnableAdapter<void
(__thiscall content::BrowserTestBase::*)(void)>,void
__cdecl(content::BrowserTestBase *),void __cdecl(content::BrowserTestBase
*)>,void __cdecl(content::BrowserTestBa [0x01A8B715+69]
base::Callback<void __cdecl(void)>::Run [0x004D6ECF+47]
ChromeBrowserMainParts::PreMainMessageLoopRunImpl [0x02B3970F+7359]
ChromeBrowserMainParts::PreMainMessageLoopRun [0x02B36E39+233]
content::BrowserMainLoop::CreateThreads [0x0B6F1B4E+2846]
content::BrowserMainRunnerImpl::Initialize [0x0B70056D+893]
content::BrowserMain [0x0B6ED2F9+153]
content::BrowserTestBase::SetUp [0x01A8AA29+425]
InProcessBrowserTest::SetUp [0x011CF3DF+1391]
testing::internal::HandleExceptionsInMethodIfSupported<testing::Test,void>
[0x0311F1BF+319]
testing::Test::Run [0x0310C27B+107]
testing::TestInfo::Run [0x0310CC8D+221]
testing::TestCase::Run [0x0310D45F+239]
testing::internal::UnitTestImpl::RunAllTests [0x03113CBD+701]
testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl,bool>
[0x0311FBB7+327]
testing::UnitTest::Run [0x03112520+192]
base::TestSuite::Run [0x032EAF60+240]
ChromeTestLauncherDelegate::RunTestSuite [0x00FF3185+101]
content::LaunchTests [0x01A7C0D3+1123]
main [0x00FF2FA6+86]
__tmainCRTStartup [0x03AE691F+447]
(f:\dd\vctools\crt_bld\self_x86\crt\src\crtexe.c:555)
mainCRTStartup [0x03AE674F+15]
(f:\dd\vctools\crt_bld\self_x86\crt\src\crtexe.c:371)
BaseThreadInitThunk [0x75D933AA+18]
RtlInitializeExceptionChain [0x77019EF2+99]
RtlInitializeExceptionChain [0x77019EC5+54]
Starting tests...
IMPORTANT DEBUGGING NOTE: each test is run inside its own process.
For debugging a test inside a debugger, use the
--gtest_filter=<your_test_name> flag along with either
--single_process (to run the test in one launcher/browser process) or
--single-process (to do the above, and also run Chrome in single-process mode).
1 test run
1 test failed (0 ignored)
Failing tests:
WebNavigationApiTest.RequestOpenTab

Powered by Google App Engine
This is Rietveld 408576698