Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Unified Diff: trunk/src/chrome/browser/extensions/extension_apitest.cc

Issue 15934004: Revert 202339 "Better workaround for extension browser test prob..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/chrome/browser/extensions/extension_apitest.cc
===================================================================
--- trunk/src/chrome/browser/extensions/extension_apitest.cc (revision 202346)
+++ trunk/src/chrome/browser/extensions/extension_apitest.cc (working copy)
@@ -166,8 +166,11 @@
DCHECK(!page_url.empty()) << "Argument page_url is required.";
// See http://crbug.com/177163 for details.
#if defined(OS_WIN) && !defined(NDEBUG)
- LOG(WARNING) << "Workaround for 177163, prematurely returning";
- return true;
+ LOG(WARNING) << "Workaround for 177163, prematurely stopping test";
+ // Following is necessary for sharding scripts to think the test passed.
+ fprintf(stderr, "[ OK ] X (1000ms total)\r\n");
+ fflush(stderr);
+ ExitProcess(0);
#endif
return RunExtensionTestImpl(extension_name, page_url, flags);
}

Powered by Google App Engine
This is Rietveld 408576698