Fix undefined GYP_MSVS_VERSION failure for non-googlers

Fix undefined GYP_MSVS_VERSION failure for non-googlers

This CL adds the missing GYP_MSVS_VERSION environment variable. Without
the patch the following error happen when a non-googler runs
gyp_chromium in Windows.

  File "E:\chromium\src\tools\gyp\pylib\gyp\MSVSVersion.py", line 430, in SelectVisualStudioVersion
    raise ValueError('GYP_MSVS_OVERRIDE_PATH requires GYP_MSVS_VERSION to be '
ValueError: GYP_MSVS_OVERRIDE_PATH requires GYP_MSVS_VERSION to be set to a particular version (e.g. 2010e).

The discussion is found here:
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/XWZ3hZW8Lco

BUG=460462
Committed: https://crrev.com/833a437f479bdd1653b0eff8fb5e75883df7ae88
Cr-Commit-Position: refs/heads/master@{#370065}

[lwchkg, 2016-01-17 13:30:37]

Description was changed from

==========
Fix gyp_chromium.py failure for non-googlers.

BUG=460462
==========

to

==========
Fix gyp_chromium.py failure for non-googlers.

The discussion is found here:
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/XWZ3hZW8Lco

BUG=460462
==========

[lwchkg, 2016-01-17 13:30:37]

lwchkg@gmail.com changed reviewers:
+ brucedawson@chromium.org, scottmg@chromium.org

[lwchkg, 2016-01-17 13:33:51]

Dear Scott,

  PTAL. This CL is urgent.

Regards,
WC Leung.

c.c. Bruce, Daniel

[Daniel Bratell, 2016-01-18 08:46:52]

On 2016/01/17 13:33:51, lwchkg wrote:
> Dear Scott,
> 
>   PTAL. This CL is urgent.
> 
> Regards,
> WC Leung.
> 
> c.c. Bruce, Daniel

lgtm (non-owner) though you could could improve on the commit message.

[lwchkg, 2016-01-18 11:19:06]

Description was changed from

==========
Fix gyp_chromium.py failure for non-googlers.

The discussion is found here:
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/XWZ3hZW8Lco

BUG=460462
==========

to

==========
This CL adds the missing GYP_MSVS_VERSION environment variable. Without the
patch the following error happen when a non-googler run gyp_chromium in Windows.

  File "E:\chromium\src\tools\gyp\pylib\gyp\MSVSVersion.py", line 430, in
SelectVisualStudioVersion
    raise ValueError('GYP_MSVS_OVERRIDE_PATH requires GYP_MSVS_VERSION to be '
ValueError: GYP_MSVS_OVERRIDE_PATH requires GYP_MSVS_VERSION to be set to a
particular version (e.g. 2010e).

The discussion is found here:
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/XWZ3hZW8Lco

BUG=460462
==========

[lwchkg, 2016-01-18 11:19:19]

Description was changed from

==========
This CL adds the missing GYP_MSVS_VERSION environment variable. Without the
patch the following error happen when a non-googler run gyp_chromium in Windows.

  File "E:\chromium\src\tools\gyp\pylib\gyp\MSVSVersion.py", line 430, in
SelectVisualStudioVersion
    raise ValueError('GYP_MSVS_OVERRIDE_PATH requires GYP_MSVS_VERSION to be '
ValueError: GYP_MSVS_OVERRIDE_PATH requires GYP_MSVS_VERSION to be set to a
particular version (e.g. 2010e).

The discussion is found here:
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/XWZ3hZW8Lco

BUG=460462
==========

to

==========
This CL adds the missing GYP_MSVS_VERSION environment variable. Without the
patch the following error happen when a non-googler runs gyp_chromium in
Windows.

  File "E:\chromium\src\tools\gyp\pylib\gyp\MSVSVersion.py", line 430, in
SelectVisualStudioVersion
    raise ValueError('GYP_MSVS_OVERRIDE_PATH requires GYP_MSVS_VERSION to be '
ValueError: GYP_MSVS_OVERRIDE_PATH requires GYP_MSVS_VERSION to be set to a
particular version (e.g. 2010e).

The discussion is found here:
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/XWZ3hZW8Lco

BUG=460462
==========

[scottmg, 2016-01-18 18:22:59]

lgtm

[brucedawson, 2016-01-18 18:36:35]

On 2016/01/18 18:22:59, scottmg wrote:
> lgtm

Please fix the description. Specifically:

You need to copy the issue title to the first line of the description, and
follow it with a blank line. This is standard git format.

Subsequent lines of the description should, as much as possible, be a maximum of
72 characters. Occasional violations for URLs and error messages are fine.

It wouldn't hurt to have the description/first-line-of-description be more
specific. Perhaps:
"Fix undefined GYP_MSVS_VERSION failure for non-googlers"

The most important thing is to copy the title to the first line of the
description, followed by a blank line. The rest is just fussiness.

[lwchkg, 2016-01-19 00:11:39]

Description was changed from

==========
This CL adds the missing GYP_MSVS_VERSION environment variable. Without the
patch the following error happen when a non-googler runs gyp_chromium in
Windows.

  File "E:\chromium\src\tools\gyp\pylib\gyp\MSVSVersion.py", line 430, in
SelectVisualStudioVersion
    raise ValueError('GYP_MSVS_OVERRIDE_PATH requires GYP_MSVS_VERSION to be '
ValueError: GYP_MSVS_OVERRIDE_PATH requires GYP_MSVS_VERSION to be set to a
particular version (e.g. 2010e).

The discussion is found here:
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/XWZ3hZW8Lco

BUG=460462
==========

to

==========
Fix undefined GYP_MSVS_VERSION failure for non-googlers

This CL adds the missing GYP_MSVS_VERSION environment variable. Without
the patch the following error happen when a non-googler runs
gyp_chromium in Windows.

  File "E:\chromium\src\tools\gyp\pylib\gyp\MSVSVersion.py", line 430, in
SelectVisualStudioVersion
    raise ValueError('GYP_MSVS_OVERRIDE_PATH requires GYP_MSVS_VERSION to be '
ValueError: GYP_MSVS_OVERRIDE_PATH requires GYP_MSVS_VERSION to be set to a
particular version (e.g. 2010e).

The discussion is found here:
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/XWZ3hZW8Lco

BUG=460462
==========

[lwchkg, 2016-01-19 00:15:51]

Thanks Bruce and Daniel for the comments! I've just made another try in the
commit message. Hope that it works well!

[lwchkg, 2016-01-19 00:16:08]

The CQ bit was checked by lwchkg@gmail.com

[commit-bot: I haz the power, 2016-01-19 00:16:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1593313002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1593313002/1

[commit-bot: I haz the power, 2016-01-19 00:39:16]

Description was changed from

==========
Fix undefined GYP_MSVS_VERSION failure for non-googlers

This CL adds the missing GYP_MSVS_VERSION environment variable. Without
the patch the following error happen when a non-googler runs
gyp_chromium in Windows.

  File "E:\chromium\src\tools\gyp\pylib\gyp\MSVSVersion.py", line 430, in
SelectVisualStudioVersion
    raise ValueError('GYP_MSVS_OVERRIDE_PATH requires GYP_MSVS_VERSION to be '
ValueError: GYP_MSVS_OVERRIDE_PATH requires GYP_MSVS_VERSION to be set to a
particular version (e.g. 2010e).

The discussion is found here:
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/XWZ3hZW8Lco

BUG=460462
==========

to

==========
Fix undefined GYP_MSVS_VERSION failure for non-googlers

This CL adds the missing GYP_MSVS_VERSION environment variable. Without
the patch the following error happen when a non-googler runs
gyp_chromium in Windows.

  File "E:\chromium\src\tools\gyp\pylib\gyp\MSVSVersion.py", line 430, in
SelectVisualStudioVersion
    raise ValueError('GYP_MSVS_OVERRIDE_PATH requires GYP_MSVS_VERSION to be '
ValueError: GYP_MSVS_OVERRIDE_PATH requires GYP_MSVS_VERSION to be set to a
particular version (e.g. 2010e).

The discussion is found here:
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/XWZ3hZW8Lco

BUG=460462
==========

[commit-bot: I haz the power, 2016-01-19 00:39:17]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-01-19 00:40:59]

Description was changed from

==========
Fix undefined GYP_MSVS_VERSION failure for non-googlers

This CL adds the missing GYP_MSVS_VERSION environment variable. Without
the patch the following error happen when a non-googler runs
gyp_chromium in Windows.

  File "E:\chromium\src\tools\gyp\pylib\gyp\MSVSVersion.py", line 430, in
SelectVisualStudioVersion
    raise ValueError('GYP_MSVS_OVERRIDE_PATH requires GYP_MSVS_VERSION to be '
ValueError: GYP_MSVS_OVERRIDE_PATH requires GYP_MSVS_VERSION to be set to a
particular version (e.g. 2010e).

The discussion is found here:
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/XWZ3hZW8Lco

BUG=460462
==========

to

==========
Fix undefined GYP_MSVS_VERSION failure for non-googlers

This CL adds the missing GYP_MSVS_VERSION environment variable. Without
the patch the following error happen when a non-googler runs
gyp_chromium in Windows.

  File "E:\chromium\src\tools\gyp\pylib\gyp\MSVSVersion.py", line 430, in
SelectVisualStudioVersion
    raise ValueError('GYP_MSVS_OVERRIDE_PATH requires GYP_MSVS_VERSION to be '
ValueError: GYP_MSVS_OVERRIDE_PATH requires GYP_MSVS_VERSION to be set to a
particular version (e.g. 2010e).

The discussion is found here:
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/XWZ3hZW8Lco

BUG=460462

Committed: https://crrev.com/833a437f479bdd1653b0eff8fb5e75883df7ae88
Cr-Commit-Position: refs/heads/master@{#370065}
==========

[commit-bot: I haz the power, 2016-01-19 00:40:59]

Patchset 1 (id:??) landed as
https://crrev.com/833a437f479bdd1653b0eff8fb5e75883df7ae88
Cr-Commit-Position: refs/heads/master@{#370065}

[brucedawson, 2016-01-19 17:53:49]

On 2016/01/19 00:15:51, lwchkg wrote:
> Thanks Bruce and Daniel for the comments! I've just made another try in the
> commit message. Hope that it works well!

Commit message looks perfect. Thanks.