build/vs_toolchain.py - Issue 1593313002: Fix undefined GYP_MSVS_VERSION failure for non-googlers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/vs_toolchain.py

Issue 1593313002: Fix undefined GYP_MSVS_VERSION failure for non-googlers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/vs_toolchain.py

diff --git a/build/vs_toolchain.py b/build/vs_toolchain.py

index 6a0e6c95e915775a415cad2db4f9eb5a0f48ffc9..66a3cd8e8640147ffaa07bd930dc3252f99bd45e 100755

--- a/build/vs_toolchain.py

+++ b/build/vs_toolchain.py

@@ -71,6 +71,8 @@ def SetEnvironmentAndGetRuntimeDllDirs():

elif sys.platform == 'win32' and not depot_tools_win_toolchain:

if not 'GYP_MSVS_OVERRIDE_PATH' in os.environ:

os.environ['GYP_MSVS_OVERRIDE_PATH'] = DetectVisualStudioPath()

+ if not 'GYP_MSVS_VERSION' in os.environ:

+ os.environ['GYP_MSVS_VERSION'] = GetVisualStudioVersion()

return vs_runtime_dll_dirs

« no previous file with comments | « no previous file | no next file » | no next file with comments »