Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(516)

Unified Diff: chrome/browser/gtk/options/advanced_contents_gtk.cc

Issue 159326: Make some default file dialog titles.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: another new string Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/app/generated_resources.grd ('K') | « chrome/browser/gtk/dialogs_gtk.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/gtk/options/advanced_contents_gtk.cc
===================================================================
--- chrome/browser/gtk/options/advanced_contents_gtk.cc (revision 21563)
+++ chrome/browser/gtk/options/advanced_contents_gtk.cc (working copy)
@@ -112,10 +112,8 @@
// Download location options.
download_location_button_ = gtk_file_chooser_button_new(
- // TODO(mattm): There doesn't seem to be a reasonable localized string for
- // the chooser title? (Though no other file choosers have a title either,
- // bug 16890.)
- "",
+ l10n_util::GetStringUTF8(
+ IDS_OPTIONS_DOWNLOADLOCATION_BROWSE_TITLE2).c_str(),
GTK_FILE_CHOOSER_ACTION_SELECT_FOLDER);
g_signal_connect(download_location_button_, "selection-changed",
G_CALLBACK(OnDownloadLocationChanged), this);
« chrome/app/generated_resources.grd ('K') | « chrome/browser/gtk/dialogs_gtk.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698