Make some default file dialog titles....

Make some default file dialog titles for linux.

Seems Windows only lets you set some text inside the dialog above the tree view, and not in the titlebar.

BUG=16890
TEST=should be obvious


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21600

[Evan Stade, 2009-07-24 02:37:26]

I added IDS_OPTIONS_DOWNLOADLOCATION_BROWSE_TITLE as the title for the download
location folder browser. The problem is that string is "Download location:"
which is a bit weird as a window title. I don't understand why windows puts this
string where it does. IMO It should be changed to Download Location and used as
the window title on both windows and linux (on windows the title is currently
"Browse For Folder"). Ben?

[Evan Stade, 2009-07-24 02:39:32]

sorry, unclear: s/why windows puts/why Chrome on MSWindows puts/

[Evan Stade, 2009-07-24 03:29:57]

ok so I guess that on windows you can't set the window title:

lpszTitle
Pointer to a null-terminated string that is displayed above the tree view
control in the dialog box. This string can be used to specify instructions to
the user.

Should we create a new string?

[Evan Stade, 2009-07-24 21:03:46]

added a new string

[Evan Stade, 2009-07-24 23:03:13]

string freeze draws near...

[Evan Martin, 2009-07-24 23:13:02]

LGTM whichever way, but def don't use TITLE2

http://codereview.chromium.org/159326/diff/1014/1015
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/159326/diff/1014/1015#newcode3199
Line 3199: <message name="IDS_OPTIONS_DOWNLOADLOCATION_BROWSE_TITLE2" desc="In
the 'Browse For Folder' dialog on Linux, this is the text that appears in the
title bar.">
maybe WINDOW_TITLE or something?  TITLE2 is weird

http://codereview.chromium.org/159326/diff/1014/1015#newcode4238
Line 4238: <message name="IDS_SAVE_AS_DIALOG_TITLE" desc="The default title for
the Save As file chooser dialog.">
Does "default" mean that it can be overridden somehow?  Otherwise maybe just
"The title for ..."

[Evan Stade, 2009-07-24 23:16:44]

http://codereview.chromium.org/159326/diff/1014/1015
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/159326/diff/1014/1015#newcode3199
Line 3199: <message name="IDS_OPTIONS_DOWNLOADLOCATION_BROWSE_TITLE2" desc="In
the 'Browse For Folder' dialog on Linux, this is the text that appears in the
title bar.">
On 2009/07/24 23:13:02, Evan Martin wrote:
> maybe WINDOW_TITLE or something?  TITLE2 is weird

guess I had prefs::kBookmarkTableURLWidth2 in mind when I named it. Will change.

http://codereview.chromium.org/159326/diff/1014/1015#newcode4238
Line 4238: <message name="IDS_SAVE_AS_DIALOG_TITLE" desc="The default title for
the Save As file chooser dialog.">
On 2009/07/24 23:13:02, Evan Martin wrote:
> Does "default" mean that it can be overridden somehow?  Otherwise maybe just
> "The title for ..."

yes, if a web page asks us to use a specific title, we will. Also if later on we
want to have more specific names for certain file choosers then they will
override these defaults.