Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 159326: Make some default file dialog titles.... (Closed)

Created:
11 years, 5 months ago by Evan Stade
Modified:
9 years, 6 months ago
CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)
Visibility:
Public.

Description

Make some default file dialog titles for linux. Seems Windows only lets you set some text inside the dialog above the tree view, and not in the titlebar. BUG=16890 TEST=should be obvious Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21600

Patch Set 1 #

Patch Set 2 : string changed #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : another new string #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -8 lines) Patch
M chrome/app/generated_resources.grd View 1 2 3 4 2 chunks +15 lines, -1 line 4 comments Download
M chrome/browser/gtk/dialogs_gtk.cc View 1 2 3 4 3 chunks +12 lines, -3 lines 0 comments Download
M chrome/browser/gtk/options/advanced_contents_gtk.cc View 3 4 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Evan Stade
11 years, 5 months ago (2009-07-24 02:14:06 UTC) #1
Evan Stade
I added IDS_OPTIONS_DOWNLOADLOCATION_BROWSE_TITLE as the title for the download location folder browser. The problem is ...
11 years, 5 months ago (2009-07-24 02:37:26 UTC) #2
Evan Stade
sorry, unclear: s/why windows puts/why Chrome on MSWindows puts/
11 years, 5 months ago (2009-07-24 02:39:32 UTC) #3
Evan Stade
ok so I guess that on windows you can't set the window title: lpszTitle Pointer ...
11 years, 5 months ago (2009-07-24 03:29:57 UTC) #4
Evan Stade
added a new string
11 years, 5 months ago (2009-07-24 21:03:46 UTC) #5
Evan Stade
string freeze draws near...
11 years, 5 months ago (2009-07-24 23:03:13 UTC) #6
Evan Martin
LGTM whichever way, but def don't use TITLE2 http://codereview.chromium.org/159326/diff/1014/1015 File chrome/app/generated_resources.grd (right): http://codereview.chromium.org/159326/diff/1014/1015#newcode3199 Line 3199: ...
11 years, 5 months ago (2009-07-24 23:13:02 UTC) #7
Evan Stade
11 years, 5 months ago (2009-07-24 23:16:44 UTC) #8
http://codereview.chromium.org/159326/diff/1014/1015
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/159326/diff/1014/1015#newcode3199
Line 3199: <message name="IDS_OPTIONS_DOWNLOADLOCATION_BROWSE_TITLE2" desc="In
the 'Browse For Folder' dialog on Linux, this is the text that appears in the
title bar.">
On 2009/07/24 23:13:02, Evan Martin wrote:
> maybe WINDOW_TITLE or something?  TITLE2 is weird

guess I had prefs::kBookmarkTableURLWidth2 in mind when I named it. Will change.

http://codereview.chromium.org/159326/diff/1014/1015#newcode4238
Line 4238: <message name="IDS_SAVE_AS_DIALOG_TITLE" desc="The default title for
the Save As file chooser dialog.">
On 2009/07/24 23:13:02, Evan Martin wrote:
> Does "default" mean that it can be overridden somehow?  Otherwise maybe just
> "The title for ..."

yes, if a web page asks us to use a specific title, we will. Also if later on we
want to have more specific names for certain file choosers then they will
override these defaults.

Powered by Google App Engine
This is Rietveld 408576698