Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(858)

Issue 1593024: We should not include -lnosys on ARM: it comes automatically and will spoil... (Closed)

Created:
10 years, 8 months ago by khimg
Modified:
9 years, 7 months ago
Reviewers:
robertm, bradn
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

We should not include -lnosys on ARM: it comes automatically and will spoil things if included before -lc Committed: http://code.google.com/p/nativeclient/source/detail?r=2047

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Total comments: 1

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -6 lines) Patch
tests/file/nacl.scons View 1 2 1 chunk +7 lines, -2 lines 0 comments Download
tests/sysbasic/nacl.scons View 1 2 1 chunk +7 lines, -3 lines 0 comments Download
tools/tests/nacl.scons View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
khimg
10 years, 8 months ago (2010-04-13 20:20:50 UTC) #1
bradn
LGTM http://codereview.chromium.org/1593024/diff/1/2 File tests/file/nacl.scons (right): http://codereview.chromium.org/1593024/diff/1/2#newcode37 tests/file/nacl.scons:37: EXTRA_LIBS=(['pthread', 'nosys'],['pthread'])[ A separate if statement storing into ...
10 years, 8 months ago (2010-04-13 20:24:39 UTC) #2
bradn
http://codereview.chromium.org/1593024/diff/5001/6002 File tests/sysbasic/nacl.scons (right): http://codereview.chromium.org/1593024/diff/5001/6002#newcode34 tests/sysbasic/nacl.scons:34: if env['TARGET_ARCHITECTURE'] == 'arm']: extra ] on the end. ...
10 years, 8 months ago (2010-04-13 20:31:48 UTC) #3
bradn
10 years, 8 months ago (2010-04-13 20:35:02 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698