Issue 1593009: Add extra views to the new net internals page. This adds tabs along the top f...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1593009: Add extra views to the new net internals page. This adds tabs along the top f... (Closed)

Created:
10 years, 8 months ago by eroman

Modified:
9 years, 6 months ago

Reviewers:
Mike Belshe

CC:
chromium-reviews, arv (Not doing code reviews), ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Add extra views to the new net internals page. This adds tabs along the top for proxy, dns, sockets, requests, and http cache subsections. The actual subviews are placeholders. BUG=37421 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=43502

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+643 lines, -449 lines)			Patch
M	chrome/browser/resources/net_internals/detailsview.js	View		1 chunk	+86 lines, -53 lines	0 comments	Download
M	chrome/browser/resources/net_internals/index.html	View		3 chunks	+32 lines, -9 lines	0 comments	Download
D	chrome/browser/resources/net_internals/layoutmanager.js	View		1 chunk	+0 lines, -151 lines	0 comments	Download
M	chrome/browser/resources/net_internals/main.css	View		2 chunks	+52 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/net_internals/main.js	View		1 chunk	+39 lines, -18 lines	0 comments	Download
M	chrome/browser/resources/net_internals/requestsview.js	View	1	2 chunks	+50 lines, -8 lines	0 comments	Download
A +	chrome/browser/resources/net_internals/resizableverticalsplitview.js	View		2 chunks	+51 lines, -77 lines	0 comments	Download
A	chrome/browser/resources/net_internals/tabswitcherview.js	View		1 chunk	+141 lines, -0 lines	0 comments	Download
A +	chrome/browser/resources/net_internals/topmidbottomview.js	View		1 chunk	+40 lines, -132 lines	0 comments	Download
M	chrome/browser/resources/net_internals/util.js	View		2 chunks	+18 lines, -0 lines	0 comments	Download
A	chrome/browser/resources/net_internals/view.js	View		1 chunk	+130 lines, -0 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View		1 chunk	+4 lines, -1 line	0 comments	Download

Total messages: 2 (0 generated)

Nice refactoring of the Views and inheritance.

LGTM