Chromium Code Reviews
Help | Chromium Project | Sign in
(825)

Issue 1593009: Add extra views to the new net internals page. This adds tabs along the top f... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years ago by eroman
Modified:
2 years, 10 months ago
Reviewers:
Mike Belshe
CC:
chromium-reviews_chromium.org, arv, ben+cc_chromium.org
Visibility:
Public.

Description

Add extra views to the new net internals page. This adds tabs along the top for proxy, dns, sockets, requests, and http cache subsections. The actual subviews are placeholders.

BUG=37421
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=43502

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+643 lines, -449 lines) Lint Patch
M chrome/browser/resources/net_internals/detailsview.js View 1 chunk +86 lines, -53 lines 0 comments 0 errors Download
M chrome/browser/resources/net_internals/index.html View 3 chunks +32 lines, -9 lines 0 comments 0 errors Download
D chrome/browser/resources/net_internals/layoutmanager.js View 1 chunk +0 lines, -151 lines 0 comments 0 errors Download
M chrome/browser/resources/net_internals/main.css View 2 chunks +52 lines, -0 lines 0 comments 0 errors Download
M chrome/browser/resources/net_internals/main.js View 1 chunk +39 lines, -18 lines 0 comments 0 errors Download
M chrome/browser/resources/net_internals/requestsview.js View 1 2 chunks +50 lines, -8 lines 0 comments 0 errors Download
A + chrome/browser/resources/net_internals/resizableverticalsplitview.js View 2 chunks +51 lines, -77 lines 0 comments 0 errors Download
A chrome/browser/resources/net_internals/tabswitcherview.js View 1 chunk +141 lines, -0 lines 0 comments 0 errors Download
A + chrome/browser/resources/net_internals/topmidbottomview.js View 1 chunk +40 lines, -132 lines 0 comments 0 errors Download
M chrome/browser/resources/net_internals/util.js View 2 chunks +18 lines, -0 lines 0 comments 0 errors Download
A chrome/browser/resources/net_internals/view.js View 1 chunk +130 lines, -0 lines 0 comments 0 errors Download
M chrome/chrome_browser.gypi View 1 chunk +4 lines, -1 line 0 comments 0 errors Download
Trybot results:
Commit:

Messages

Total messages: 2
eroman
4 years ago #1
Mike Belshe
4 years ago #2
Nice refactoring of the Views and inheritance.

LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6