Issue 1593002: Revert "VBoot Reference: Refactor Part 2 - Crypto Libraries"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1593002: Revert "VBoot Reference: Refactor Part 2 - Crypto Libraries" (Closed)

Created:
10 years, 8 months ago by dhg

Modified:
9 years, 7 months ago

Reviewers:
Daniel Erat

CC:
chromium-os-reviews_chromium.org

Visibility:
Public.

Description

Revert "VBoot Reference: Refactor Part 2 - Crypto Libraries" This reverts commit e018a80a37aaa45681f45f5852f04d20aedd8b2d.

Patch Set 1 #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+255 lines, -234 lines)			Patch
M	src/platform/vboot_reference/crypto/genpadding.sh	View	1 chunk	+0 lines, -12 lines	0 comments	Download
M	src/platform/vboot_reference/crypto/padding.c	View	3 chunks	+4 lines, -16 lines	0 comments	Download
M	src/platform/vboot_reference/crypto/rsa.c	View	4 chunks	+9 lines, -6 lines	0 comments	Download
M	src/platform/vboot_reference/crypto/rsa_utility.c	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	src/platform/vboot_reference/crypto/sha1.c	View	2 chunks	+5 lines, -6 lines	0 comments	Download
M	src/platform/vboot_reference/crypto/sha2.c	View	5 chunks	+6 lines, -6 lines	0 comments	Download
M	src/platform/vboot_reference/crypto/sha_utility.c	View	2 chunks	+48 lines, -2 lines	0 comments	Download
D	src/platform/vboot_reference/include/cryptolib.h	View	1 chunk	+0 lines, -15 lines	0 comments	Download
M	src/platform/vboot_reference/include/file_keys.h	View	2 chunks	+1 line, -7 lines	0 comments	Download
M	src/platform/vboot_reference/include/firmware_image_fw.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/platform/vboot_reference/include/kernel_image_fw.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/platform/vboot_reference/include/padding.h	View	2 chunks	+1 line, -6 lines	0 comments	Download
M	src/platform/vboot_reference/include/rsa.h	View	2 chunks	+5 lines, -59 lines	0 comments	Download
A	src/platform/vboot_reference/include/rsa_utility.h	View	1 chunk	+58 lines, -0 lines	0 comments	Download
M	src/platform/vboot_reference/include/sha.h	View	2 chunks	+2 lines, -46 lines	0 comments	Download
A	src/platform/vboot_reference/include/sha_utility.h	View	1 chunk	+53 lines, -0 lines	0 comments	Download
M	src/platform/vboot_reference/tests/big_firmware_tests.c	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/platform/vboot_reference/tests/big_kernel_tests.c	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/platform/vboot_reference/tests/firmware_image_tests.c	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/platform/vboot_reference/tests/firmware_rollback_tests.c	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/platform/vboot_reference/tests/firmware_splicing_tests.c	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/platform/vboot_reference/tests/firmware_verify_benchmark.c	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/platform/vboot_reference/tests/kernel_image_tests.c	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/platform/vboot_reference/tests/kernel_rollback_tests.c	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/platform/vboot_reference/tests/kernel_splicing_tests.c	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/platform/vboot_reference/tests/kernel_verify_benchmark.c	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/platform/vboot_reference/tests/rollback_index_mock.c	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/platform/vboot_reference/tests/rsa_padding_test.h	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	src/platform/vboot_reference/tests/rsa_padding_test.c	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/platform/vboot_reference/tests/rsa_verify_benchmark.c	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	src/platform/vboot_reference/tests/sha_benchmark.c	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/platform/vboot_reference/tests/sha_tests.c	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/platform/vboot_reference/tests/test_common.c	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/platform/vboot_reference/utils/file_keys.c	View	2 chunks	+2 lines, -22 lines	0 comments	Download
M	src/platform/vboot_reference/utils/firmware_image.c	View	1 chunk	+5 lines, -2 lines	0 comments	Download
M	src/platform/vboot_reference/utils/firmware_image_fw.c	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	src/platform/vboot_reference/utils/firmware_utility.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	src/platform/vboot_reference/utils/kernel_image.c	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	src/platform/vboot_reference/utils/kernel_image_fw.c	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	src/platform/vboot_reference/utils/kernel_utility.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	src/platform/vboot_reference/utils/signature_digest.c	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	src/platform/vboot_reference/utils/verify_data.c	View	1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

LGTM if it builds now.  Thanks!

Expand Messages | Collapse Messages