Differentiate maxColorSamples and maxStencilSamples in GrCaps

Differentiate maxColorSamples and maxStencilSamples in GrCaps

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1592803002

Committed: https://skia.googlesource.com/skia/+/eed519e6a2d0e61b0733a388de9320af897ed197

[egdaniel, 2016-01-15 18:00:40]

Description was changed from

==========
Differentiate maxColorSamples and maxStencilSamples in GrCaps

BUG=skia:
==========

to

==========
Differentiate maxColorSamples and maxStencilSamples in GrCaps

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[egdaniel, 2016-01-15 18:02:49]

egdaniel@google.com changed reviewers:
+ bsalomon@google.com

[egdaniel, 2016-01-15 18:02:50]

Currently in skia's use case of mixed samples, there are no other values we need
to be checking for color or stencil samples

[bsalomon, 2016-01-15 18:08:29]

https://codereview.chromium.org/1592803002/diff/1/src/gpu/GrContext.cpp
File src/gpu/GrContext.cpp (right):

https://codereview.chromium.org/1592803002/diff/1/src/gpu/GrContext.cpp#newco...
src/gpu/GrContext.cpp:575: bool validSampleCount = chosenSampleCount <=
fGpu->caps()->maxColorSampleCount() &&
Might need a check for mixed samples support here. If we're using it I think we
only care about stencil count

https://codereview.chromium.org/1592803002/diff/1/src/gpu/gl/GrGLGpu.cpp
File src/gpu/gl/GrGLGpu.cpp (right):

https://codereview.chromium.org/1592803002/diff/1/src/gpu/gl/GrGLGpu.cpp#newc...
src/gpu/gl/GrGLGpu.cpp:490: surfDesc.fSampleCnt = SkTMin(desc.fSampleCnt,
maxSampleCount);
Probably want to consider mixed samples here

https://codereview.chromium.org/1592803002/diff/1/src/gpu/gl/GrGLGpu.cpp#newc...
src/gpu/gl/GrGLGpu.cpp:544: desc.fSampleCnt = SkTMin(wrapDesc.fSampleCnt,
maxSampleCount);
and here

[egdaniel, 2016-01-15 19:20:36]

updated so maxSampleCount now takes mixedSamples into account

[bsalomon, 2016-01-15 19:24:07]

lgtm

[egdaniel, 2016-01-15 19:25:18]

The CQ bit was checked by egdaniel@google.com

[commit-bot: I haz the power, 2016-01-15 19:25:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1592803002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1592803002/20001

[commit-bot: I haz the power, 2016-01-15 19:36:20]

Description was changed from

==========
Differentiate maxColorSamples and maxStencilSamples in GrCaps

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Differentiate maxColorSamples and maxStencilSamples in GrCaps

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/eed519e6a2d0e61b0733a388de9320af897ed197
==========

[commit-bot: I haz the power, 2016-01-15 19:36:20]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/eed519e6a2d0e61b0733a388de9320af897ed197