src/ast/ast.cc - Issue 1592713002: Clean up dead code after spread desugaring

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ast/ast.cc

Issue 1592713002: Clean up dead code after spread desugaring (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fix bug that visited dead AST node in for/of Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ast/ast.cc

diff --git a/src/ast/ast.cc b/src/ast/ast.cc

index 30fcf9905379db9df15c6deea980cf651546b846..068b36c7438cb3430d1d90d25e2b7183f294f7b6 100644

--- a/src/ast/ast.cc

+++ b/src/ast/ast.cc

@@ -574,7 +574,7 @@ void ArrayLiteral::AssignFeedbackVectorSlots(Isolate* isolate,

int array_index = 0;

for (; array_index < values()->length(); array_index++) {

Expression* subexpr = values()->at(array_index);

- if (subexpr->IsSpread()) break;

+ DCHECK(!subexpr->IsSpread());

if (CompileTimeValue::IsCompileTimeValue(subexpr)) continue;

// We'll reuse the same literal slot for all of the non-constant

« no previous file with comments | « no previous file | src/ast/ast-literal-reindexer.cc » ('j') | no next file with comments »