Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 1591953005: Make ScrollbarThemeAura selectively invalidate scrollbar parts. (Closed)

Created:
4 years, 11 months ago by jbroman
Modified:
4 years, 11 months ago
Reviewers:
skobes
CC:
blink-reviews, chromium-reviews, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make ScrollbarThemeAura selectively invalidate scrollbar parts. In particular: - when hovering or pressing the thumb, repaint only the thumb - when thumb position changes, repaint the track only if it changes (e.g. due to a button being disabled upon reaching the end) This CL was broken out of https://codereview.chromium.org/1558493002/ after landing that one lead to issues that are difficult to isolate. BUG=549277 Committed: https://crrev.com/14716e7723fcfc898c78b52943b53c5a6074194e Cr-Commit-Position: refs/heads/master@{#370142}

Patch Set 1 #

Total comments: 2

Patch Set 2 : merge with master; remove blank line #

Messages

Total messages: 10 (4 generated)
jbroman
This is the CL that moves Aura over to the piecewise scrollbar invalidation path, with ...
4 years, 11 months ago (2016-01-17 00:32:40 UTC) #2
skobes
lgtm https://codereview.chromium.org/1591953005/diff/1/third_party/WebKit/Source/platform/scroll/ScrollableAreaTest.cpp File third_party/WebKit/Source/platform/scroll/ScrollableAreaTest.cpp (right): https://codereview.chromium.org/1591953005/diff/1/third_party/WebKit/Source/platform/scroll/ScrollableAreaTest.cpp#newcode213 third_party/WebKit/Source/platform/scroll/ScrollableAreaTest.cpp:213: nit: extra blank line
4 years, 11 months ago (2016-01-19 04:29:51 UTC) #3
jbroman
https://codereview.chromium.org/1591953005/diff/1/third_party/WebKit/Source/platform/scroll/ScrollableAreaTest.cpp File third_party/WebKit/Source/platform/scroll/ScrollableAreaTest.cpp (right): https://codereview.chromium.org/1591953005/diff/1/third_party/WebKit/Source/platform/scroll/ScrollableAreaTest.cpp#newcode213 third_party/WebKit/Source/platform/scroll/ScrollableAreaTest.cpp:213: On 2016/01/19 at 04:29:51, skobes wrote: > nit: extra ...
4 years, 11 months ago (2016-01-19 15:08:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1591953005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1591953005/20001
4 years, 11 months ago (2016-01-19 15:08:22 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-19 17:57:33 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-19 17:59:03 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/14716e7723fcfc898c78b52943b53c5a6074194e
Cr-Commit-Position: refs/heads/master@{#370142}

Powered by Google App Engine
This is Rietveld 408576698