third_party/WebKit/Source/platform/scroll/Scrollbar.cpp - Issue 1591953005: Make ScrollbarThemeAura selectively invalidate scrollbar parts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/scroll/Scrollbar.cpp

Issue 1591953005: Make ScrollbarThemeAura selectively invalidate scrollbar parts. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: merge with master; remove blank line Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/scroll/Scrollbar.h ('k') | third_party/WebKit/Source/platform/scroll/ScrollbarTheme.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/scroll/Scrollbar.cpp

diff --git a/third_party/WebKit/Source/platform/scroll/Scrollbar.cpp b/third_party/WebKit/Source/platform/scroll/Scrollbar.cpp

index dd67570f155ea693fd59f513845248d6114ad8d9..f2071b4c20f820a770b309b88c196575c088ba4e 100644

--- a/third_party/WebKit/Source/platform/scroll/Scrollbar.cpp

+++ b/third_party/WebKit/Source/platform/scroll/Scrollbar.cpp

@@ -139,12 +139,14 @@ void Scrollbar::offsetDidChange()

if (position == m_currentPos)

return;

+ float oldPosition = m_currentPos;

int oldThumbPosition = theme().thumbPosition(*this);

m_currentPos = position;

- // TODO(jbroman): The theme should provide the parts to invalidate.

- // At the moment, the only theme that doesn't invalidate everything is Mac,

- // which invalidates this as needed in ScrollAnimatorMac.

- setNeedsPaintInvalidation(NoPart);

+ ScrollbarPart invalidParts = theme().invalidateOnThumbPositionChange(

+ *this, oldPosition, position);

+ setNeedsPaintInvalidation(invalidParts);

if (m_pressedPart == ThumbPart)

setPressedPos(m_pressedPos + theme().thumbPosition(*this) - oldThumbPosition);

}