Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(694)

Issue 1591893002: Subzero: Improve the usability of UnimplementedError during lowering. (Closed)

Created:
4 years, 11 months ago by Jim Stichnoth
Modified:
4 years, 11 months ago
Reviewers:
Karl, sehr, John, reed.kotler
CC:
native-client-reviews_googlegroups.com, eholk (please use chromium)
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero: Improve the usability of UnimplementedError during lowering. Provides a variant of the UnimplementedError macro specifically for use in incomplete target instruction lowering. When --skip-unimplemented is specified, the UnimplementedLoweringError macro adds FakeUse and FakeDef instructions in order to maintain consistency in liveness analysis. BUG= none R=kschimpf@google.com Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=91c773e1a2bccbb2e2f848f42fc36285cf5f12a5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -131 lines) Patch
M src/IceTargetLowering.h View 2 chunks +21 lines, -0 lines 0 comments Download
M src/IceTargetLowering.cpp View 1 chunk +20 lines, -0 lines 0 comments Download
M src/IceTargetLoweringARM32.cpp View 15 chunks +17 lines, -61 lines 0 comments Download
M src/IceTargetLoweringMIPS32.cpp View 10 chunks +71 lines, -70 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Jim Stichnoth
4 years, 11 months ago (2016-01-15 22:32:24 UTC) #3
Jim Stichnoth
Adding +eholk to the cc list because this is relevant to ARM vector lowering. (Can't ...
4 years, 11 months ago (2016-01-15 22:47:13 UTC) #4
Karl
lgtm
4 years, 11 months ago (2016-01-19 16:01:40 UTC) #5
Jim Stichnoth
4 years, 11 months ago (2016-01-19 17:52:26 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
91c773e1a2bccbb2e2f848f42fc36285cf5f12a5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698