Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(636)

Issue 1591763003: Use registerWeakMembers to clean up IntersectionObserver. (Closed)

Created:
4 years, 11 months ago by szager1
Modified:
4 years, 11 months ago
Reviewers:
haraken, sof, dcheng
CC:
chromium-reviews, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use registerWeakMembers to clean up IntersectionObserver. Pre-oilpan, when the root disappears, it observers are cleaned up in NodeIntersectionObserverData::dispose(). Post-oilpan, the cleanup will be done with registerWeakMembers. BUG=540528 R=haraken@chromium.org,dcheng@chromium.org Committed: https://crrev.com/546573354e47ddd01f491c382701fa51500f85eb Cr-Commit-Position: refs/heads/master@{#369948}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -23 lines) Patch
M third_party/WebKit/Source/core/dom/IntersectionObserver.h View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/IntersectionObserver.cpp View 7 chunks +6 lines, -21 lines 2 comments Download

Messages

Total messages: 13 (3 generated)
szager1
4 years, 11 months ago (2016-01-15 22:06:28 UTC) #1
haraken
LGTM
4 years, 11 months ago (2016-01-16 04:11:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1591763003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1591763003/1
4 years, 11 months ago (2016-01-16 06:32:38 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-16 07:36:32 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/546573354e47ddd01f491c382701fa51500f85eb Cr-Commit-Position: refs/heads/master@{#369948}
4 years, 11 months ago (2016-01-16 07:37:20 UTC) #7
sof
https://codereview.chromium.org/1591763003/diff/1/third_party/WebKit/Source/core/dom/IntersectionObserver.cpp File third_party/WebKit/Source/core/dom/IntersectionObserver.cpp (right): https://codereview.chromium.org/1591763003/diff/1/third_party/WebKit/Source/core/dom/IntersectionObserver.cpp#newcode328 third_party/WebKit/Source/core/dom/IntersectionObserver.cpp:328: #if ENABLE(OILPAN) How is this supposed to work? A ...
4 years, 11 months ago (2016-01-16 09:17:18 UTC) #9
haraken
https://codereview.chromium.org/1591763003/diff/1/third_party/WebKit/Source/core/dom/IntersectionObserver.cpp File third_party/WebKit/Source/core/dom/IntersectionObserver.cpp (right): https://codereview.chromium.org/1591763003/diff/1/third_party/WebKit/Source/core/dom/IntersectionObserver.cpp#newcode332 third_party/WebKit/Source/core/dom/IntersectionObserver.cpp:332: visitor->trace(m_root); Good point... We need to remove this.
4 years, 11 months ago (2016-01-16 09:25:18 UTC) #10
sof
On 2016/01/16 09:25:18, haraken wrote: > https://codereview.chromium.org/1591763003/diff/1/third_party/WebKit/Source/core/dom/IntersectionObserver.cpp > File third_party/WebKit/Source/core/dom/IntersectionObserver.cpp (right): > > https://codereview.chromium.org/1591763003/diff/1/third_party/WebKit/Source/core/dom/IntersectionObserver.cpp#newcode332 > ...
4 years, 11 months ago (2016-01-16 09:26:59 UTC) #11
haraken
On 2016/01/16 09:26:59, sof wrote: > On 2016/01/16 09:25:18, haraken wrote: > > > https://codereview.chromium.org/1591763003/diff/1/third_party/WebKit/Source/core/dom/IntersectionObserver.cpp ...
4 years, 11 months ago (2016-01-16 11:24:17 UTC) #12
sof
4 years, 11 months ago (2016-01-17 21:39:46 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1600243002/ by sigbjornf@opera.com.

The reason for reverting is: Broke on some tests w/ Oilpan enabled,


https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Oilpan...

backing it out.

(see also https://codereview.chromium.org/1596333002/ ).

Powered by Google App Engine
This is Rietveld 408576698