Issue 159149: Remove suppression for gtk_window_add_accel_group in BrowserWindowGtk::ConnectAccelerators.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 159149: Remove suppression for gtk_window_add_accel_group in BrowserWindowGtk::ConnectAccelerators. (Closed)

Created:
11 years, 5 months ago by Paweł Hajdan Jr.

Modified:
9 years, 7 months ago

Reviewers:
dank, Evan Stade

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Remove suppression for gtk_window_add_accel_group in BrowserWindowGtk::ConnectAccelerators. The leak seems to no longer exist. http://crbug.com/16153 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21275

Patch Set 1 #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -11 lines)			Patch
	M	tools/valgrind/memcheck/suppressions.txt	View		1 chunk	+0 lines, -11 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

it does still exist: see http://codereview.chromium.org/155921 (this is not the first time someone has removed ...

11 years, 5 months ago (2009-07-22 20:24:33 UTC) #3

Paweł Hajdan Jr.

I think it's a different leak. Valgrind bots don't complain after I removed this suppression, ...

11 years, 5 months ago (2009-07-22 20:33:03 UTC) #4

Evan Stade

11 years, 5 months ago (2009-07-22 20:37:11 UTC) #5

you're right, my mistake

-- Evan Stade



On Wed, Jul 22, 2009 at 8:33 PM, <phajdan.jr@chromium.org> wrote:
> I think it's a different leak. Valgrind bots don't complain after I
> removed this suppression, and I still see the suppression for the linked
> CL in the suppression list.
>
> http://codereview.chromium.org/159149
>

Expand Messages | Collapse Messages