Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 155921: Remove the accelerator group when closing the browser window. (Closed)

Created:
11 years, 5 months ago by Dean McNamee
Modified:
9 years, 7 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Remove the accelerator group when closing the browser window. This is something that GTK should be doing automatically when the window is destroyed, but it doesn't seem to happen. Detach it ourselves so that we don't leak the closures attached to the acclerator group. BUG=10737

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -5 lines) Patch
M chrome/browser/gtk/browser_window_gtk.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/gtk/browser_window_gtk.cc View 3 chunks +11 lines, -5 lines 1 comment Download

Messages

Total messages: 5 (0 generated)
Dean McNamee
11 years, 5 months ago (2009-07-22 11:51:32 UTC) #1
Evan Stade
don't we have other accel groups that we use that should get the same treatment? ...
11 years, 5 months ago (2009-07-22 18:21:59 UTC) #2
Evan Stade
also, should we remove the suppression
11 years, 5 months ago (2009-07-22 20:50:51 UTC) #3
Dean McNamee
We probably have others, one bug at a time. Btw, was that a LG? On ...
11 years, 5 months ago (2009-07-23 13:00:06 UTC) #4
Evan Stade
11 years, 5 months ago (2009-07-23 20:00:08 UTC) #5
On Thu, Jul 23, 2009 at 6:00 AM, <deanm@chromium.org> wrote:
> We probably have others, one bug at a time.
>
> Btw, was that a LG?

if you remove the relevant suppression (if any) LG

>
> On 2009/07/22 20:50:51, Evan Stade wrote:
>>
>> also, should we remove the suppression
>
>
>
> http://codereview.chromium.org/155921
>

Powered by Google App Engine
This is Rietveld 408576698