Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 15912003: Don't assert when serializing -mask property. (Closed)

Created:
7 years, 7 months ago by darktears
Modified:
7 years, 7 months ago
CC:
blink-reviews, apavlov+blink_chromium.org, dglazkov+blink, eae+blinkwatch
Visibility:
Public.

Description

Don't assert when serializing -mask property. In the case -webkit-mask property contains several layers, it is possible that one of the layer contains "initial" implicitly set simply because the repeat property was not specified. However when reconstructing the mask property from StylePropertySet it is possible to have for example -mask-repeat-x with a value like 'initial, repeat-x' where the first initial is implicit (the original -mask first layer did not set it). As StylePropertySet should not return implicitly set initial values we should just omit these ones. The ASSERT was triggered because of better checks before casting to CSSPrimitiveValues but in this example we should not reach that cast, we should bail out : 'initial' is not a primitive value. BUG=242931 R=apavlov@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=151074

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -0 lines) Patch
A LayoutTests/fast/masking/mask-serializing.html View 1 chunk +22 lines, -0 lines 0 comments Download
A LayoutTests/fast/masking/mask-serializing-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/StylePropertySerializer.cpp View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
darktears
7 years, 7 months ago (2013-05-23 18:20:43 UTC) #1
apavlov
Thanks a bunch! LGTM
7 years, 7 months ago (2013-05-23 18:46:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alexis.menard@intel.com/15912003/4001
7 years, 7 months ago (2013-05-23 18:55:40 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=9686
7 years, 7 months ago (2013-05-23 20:39:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alexis.menard@intel.com/15912003/4001
7 years, 7 months ago (2013-05-23 20:43:21 UTC) #5
commit-bot: I haz the power
Retried try job too often on mac_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_layout_rel&number=7089
7 years, 7 months ago (2013-05-23 22:23:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alexis.menard@intel.com/15912003/4001
7 years, 7 months ago (2013-05-24 00:21:52 UTC) #7
commit-bot: I haz the power
Retried try job too often on mac_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_layout_rel&number=7175
7 years, 7 months ago (2013-05-24 01:35:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alexis.menard@intel.com/15912003/4001
7 years, 7 months ago (2013-05-24 01:49:50 UTC) #9
commit-bot: I haz the power
Retried try job too often on mac_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_layout_rel&number=7206
7 years, 7 months ago (2013-05-24 03:06:07 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alexis.menard@intel.com/15912003/4001
7 years, 7 months ago (2013-05-24 08:20:34 UTC) #11
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=9943
7 years, 7 months ago (2013-05-24 09:48:59 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alexis.menard@intel.com/15912003/4001
7 years, 7 months ago (2013-05-24 09:50:15 UTC) #13
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=9983
7 years, 7 months ago (2013-05-24 11:23:29 UTC) #14
darktears
7 years, 7 months ago (2013-05-24 11:42:14 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 manually as r151074.

Powered by Google App Engine
This is Rietveld 408576698