Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Unified Diff: Source/core/css/StylePropertySerializer.cpp

Issue 15912003: Don't assert when serializing -mask property. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/fast/masking/mask-serializing-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/StylePropertySerializer.cpp
diff --git a/Source/core/css/StylePropertySerializer.cpp b/Source/core/css/StylePropertySerializer.cpp
index bbf02200192578b3e77853c8acf69b93274f8eb9..d343c57509c5ad3fa885fa88933c487b4122c9f8 100644
--- a/Source/core/css/StylePropertySerializer.cpp
+++ b/Source/core/css/StylePropertySerializer.cpp
@@ -596,6 +596,11 @@ String StylePropertySerializer::getLayeredShorthandValue(const StylePropertyShor
else
yValue = nextValue;
+ // background-repeat-x(y) or mask-repeat-x(y) may be like this : "initial, repeat". We can omit the implicit initial values
+ // before starting to compare their values.
+ if (value->isImplicitInitialValue() || yValue->isImplicitInitialValue())
+ continue;
+
int xId = toCSSPrimitiveValue(value.get())->getIdent();
int yId = toCSSPrimitiveValue(yValue.get())->getIdent();
if (xId != yId) {
« no previous file with comments | « LayoutTests/fast/masking/mask-serializing-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698