Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4649)

Unified Diff: blimp/client/input/blimp_input_handler_wrapper.cc

Issue 1591083002: blimp: Fix input events sent from the client to the engine (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: blimp/client/input/blimp_input_handler_wrapper.cc
diff --git a/blimp/client/input/blimp_input_handler_wrapper.cc b/blimp/client/input/blimp_input_handler_wrapper.cc
index a06c92bf58b1608642872a83281710336188dccd..62516cbb637d7c83d336aba2f9d1edb3918904fe 100644
--- a/blimp/client/input/blimp_input_handler_wrapper.cc
+++ b/blimp/client/input/blimp_input_handler_wrapper.cc
@@ -44,7 +44,16 @@ void BlimpInputHandlerWrapper::HandleWebInputEvent(
ui::InputHandlerProxy::EventDisposition disposition =
input_handler_proxy_->HandleInputEvent(*input_event);
- bool consumed = disposition == ui::InputHandlerProxy::DID_NOT_HANDLE;
+ bool consumed;
Wez 2016/01/15 20:58:18 Initialize consumed to false here!
Khushal 2016/01/15 21:03:21 Done.
+
+ switch (disposition) {
+ case ui::InputHandlerProxy::EventDisposition::DID_HANDLE:
+ case ui::InputHandlerProxy::EventDisposition::DROP_EVENT:
+ consumed = true;
+ break;
+ case ui::InputHandlerProxy::EventDisposition::DID_NOT_HANDLE:
+ consumed = false;
Wez 2016/01/15 20:58:18 nit: This case should have a break; even though it
Khushal 2016/01/15 21:03:21 Done.
+ }
main_task_runner_->PostTask(
FROM_HERE,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698