blimp: Fix input events sent from the client to the engine

blimp/client/input/blimp_input_handler_wrapper.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "blimp/client/input/blimp_input_handler_wrapper.h"
 
 #include "base/bind.h"
 #include "base/location.h"
 #include "base/logging.h"
 #include "blimp/client/input/blimp_input_manager.h"
@@ skipping 26 matching lines @@
       scoped_ptr<blink::WebInputEvent> input_event) {
   DCHECK(compositor_thread_checker_.CalledOnValidThread());
 
   // We might not have the input handler proxy anymore.
   if (!input_handler_proxy_)
     return;
 
   ui::InputHandlerProxy::EventDisposition disposition =
       input_handler_proxy_->HandleInputEvent(*input_event);
 
-  bool consumed = disposition == ui::InputHandlerProxy::DID_NOT_HANDLE;
+  bool consumed;

[Wez, 2016/01/15 20:58:18]

Initialize consumed to false here!

[Khushal, 2016/01/15 21:03:21]

Done.

+
+  switch (disposition) {
+    case ui::InputHandlerProxy::EventDisposition::DID_HANDLE:
+    case ui::InputHandlerProxy::EventDisposition::DROP_EVENT:
+      consumed = true;
+      break;
+    case ui::InputHandlerProxy::EventDisposition::DID_NOT_HANDLE:
+      consumed = false;

[Wez, 2016/01/15 20:58:18]

nit: This case should have a break; even though it's the final one, to guard
against later addition of a new case breaking things.

[Khushal, 2016/01/15 21:03:21]

Done.

+  }
 
   main_task_runner_->PostTask(
       FROM_HERE,
       base::Bind(&BlimpInputManager::DidHandleWebInputEvent,
                  input_manager_weak_ptr_,
                  base::Passed(&input_event), consumed));
 }
 
 void BlimpInputHandlerWrapper::WillShutdown() {
   DCHECK(compositor_thread_checker_.CalledOnValidThread());
@@ skipping 33 matching lines @@
 void BlimpInputHandlerWrapper::DidStopFlinging() {
   DCHECK(compositor_thread_checker_.CalledOnValidThread());
 }
 
 void BlimpInputHandlerWrapper::DidAnimateForInput() {
   DCHECK(compositor_thread_checker_.CalledOnValidThread());
 }
 
 }  // namespace client
 }  // namespace blimp