appengine/findit/waterfall/try_job_enums.py - Issue 1591003002: [Findit] Modify tryjob pipelines to trigger try jobs for test failure.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/findit/waterfall/try_job_enums.py

Issue 1591003002: [Findit] Modify tryjob pipelines to trigger try jobs for test failure. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master

Patch Set: rebase Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« appengine/findit/waterfall/test/schedule_try_job_pipeline_test.py ('K') | « appengine/findit/waterfall/test/try_job_util_test.py ('k') | appengine/findit/waterfall/try_job_pipeline.py » ('j') | appengine/findit/waterfall/try_job_result_format.md » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: appengine/findit/waterfall/try_job_enums.py

diff --git a/infra/tools/cq_stats/__main__.py b/appengine/findit/waterfall/try_job_enums.py

similarity index 50%

copy from infra/tools/cq_stats/__main__.py

copy to appengine/findit/waterfall/try_job_enums.py

index 615ca98482109deb82fe8b187040bebf29541ae2..8cb644af785108712939eb0f5f0d8f996238934e 100644

--- a/infra/tools/cq_stats/__main__.py

+++ b/appengine/findit/waterfall/try_job_enums.py

@@ -1,12 +1,14 @@

-#!/usr/bin/env python

# Use of this source code is governed by a BSD-style license that can be

# found in the LICENSE file.

-import sys

-from infra.tools.cq_stats import cq_stats

+class TryJobType():

+ type_compile = 'compile'

stgao 2016/01/28 19:33:52 IIRC, constant usually use upper-case instead of l

chanli 2016/01/28 22:40:12 Done.

+ type_test = 'test'

stgao 2016/01/28 19:33:52 It seems the 'type' in the var name is a bit redun

chanli 2016/01/28 22:40:12 Done.

-if __name__ == '__main__':

- sys.exit(cq_stats.main())

+class TryJobStatus():

stgao 2016/01/28 19:33:52 It seems duplicating common.buildbucket_client.Bui

chanli 2016/01/28 22:40:12 Done.

+ scheduled = 'SCHEDULED'

+ started = 'STARTED'

+ completed = 'COMPLETED'